Page MenuHomePhabricator

Nuance - federate out the design of NuanceSource via NuanceSourceDefinition
ClosedPublic

Authored by btrahan on Nov 14 2013, 1:04 AM.
Tags
None
Referenced Files
F14034899: D7585.diff
Sun, Nov 10, 2:48 AM
F14019516: D7585.diff
Tue, Nov 5, 10:33 PM
F14013331: D7585.id17121.diff
Sat, Nov 2, 4:11 AM
F14013307: D7585.id17195.diff
Sat, Nov 2, 4:09 AM
F14013306: D7585.id.diff
Sat, Nov 2, 4:09 AM
F14010653: D7585.diff
Thu, Oct 31, 11:33 AM
F13993534: D7585.id.diff
Tue, Oct 22, 11:31 PM
F13985900: D7585.id17121.diff
Sun, Oct 20, 11:30 PM

Details

Summary

...and get the basic edit flow "working" for a new NuanceSourceDefinition - the Phabricator Form. ...and fix a dumb bug in the query class so when you redirect to the view page / try to edit an existing NuanceSource you don't fatal.

Test Plan

played around with the edit form and it worked!

Diff Detail

Branch
n3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php:38XHP16TODO Comment
Unit
No Test Coverage

Event Timeline

Minor stuff inline.

src/applications/nuance/editor/NuanceSourceEditor.php
9–10

Consider just rendering TYPE_NAME as "alincoln created this source." if the old value is empty, instead of having a separate CREATE transaction.

src/applications/nuance/query/NuanceSourceQuery.php
38

haha oops

src/applications/nuance/source/NuanceSourceDefinition.php
95–100

Maybe consider strings instead of numbers for the constants, we'll probably never change it if we don't now.

103

"updat" typo

111

I don't understand what this method does from the comment. I'd expect scour() to be like a delete/wipe/reset of some kind.

Is this scour like "search", not scour like "clean"?

Maybe scourForNewItems or something?

113

Consider load vs get for explictness.

226

In theory we can do validation in the Editor now, although that might be more work.

btrahan updated this revision to Unknown Object (????).Nov 20 2013, 9:35 PM
  • change source type from int to string
  • address other feedback too
  • add some code to the view controller so you can see this stuff just a wee bit more