Page MenuHomePhabricator

Cache the computation of the custom block component of the markup key
ClosedPublic

Authored by epriestley on Nov 13 2013, 11:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 14 2024, 8:24 AM
Unknown Object (File)
Feb 9 2024, 1:44 PM
Unknown Object (File)
Jan 22 2024, 9:38 AM
Unknown Object (File)
Jan 10 2024, 5:08 PM
Unknown Object (File)
Jan 1 2024, 5:17 AM
Unknown Object (File)
Dec 22 2023, 4:21 AM
Unknown Object (File)
Dec 19 2023, 3:56 AM
Unknown Object (File)
Dec 16 2023, 1:32 PM
Subscribers

Details

Summary

Caught this taking way too long on a production profile:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-vfzq3sregh5xvpf5nc2t/?symbol=PhabricatorMarkupEngine::getMarkupFieldKey

Cache it; it's always identical.

Test Plan

Loaded Conpherence locally.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 13 2013, 11:43 PM

Also fix a minor XHProf plugin issue.

epriestley updated this revision to Unknown Object (????).Nov 14 2013, 12:12 AM

Also improve performance of MarkupOneOff