Page MenuHomePhabricator

Phriction - make the check for project sub pages more fine-grained
ClosedPublic

Authored by btrahan on Nov 7 2013, 7:47 PM.
Tags
None
Referenced Files
F19802655: D7527.id16976.diff
Sun, Mar 1, 5:58 PM
F19504086: D7527.diff
Jan 9 2026, 3:34 AM
F19492652: D7527.id16975.diff
Jan 8 2026, 8:22 AM
F19060054: D7527.id16974.diff
Nov 29 2025, 7:48 AM
F18934868: D7527.id.diff
Nov 10 2025, 5:07 PM
F18882458: D7527.id16975.diff
Nov 6 2025, 11:00 PM
F18872944: D7527.id.diff
Nov 5 2025, 7:05 AM
F18871004: D7527.id.diff
Nov 4 2025, 8:23 PM

Details

Summary

we were just checking if projects/ was in the URI before barfing. Use some more fun utility functions such that we only complain if there is no project.

Fixes T4071.

Test Plan

made a subpage under a project - success! tried to make a project wiki page where there was no project - successful failure! tried to make a project wiki sub page where there was no project - successful failure!

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Prefer PhabricatorProjectQuery?

btrahan updated this revision to Unknown Object (????).Nov 7 2013, 8:01 PM

prefer the query class. BONUS - prefer it everywhere this little pattern appears