Page MenuHomePhabricator

Phriction - make the check for project sub pages more fine-grained
ClosedPublic

Authored by btrahan on Nov 7 2013, 7:47 PM.
Tags
None
Referenced Files
F15396450: D7527.id16975.diff
Sun, Mar 16, 2:24 PM
F15290094: D7527.diff
Tue, Mar 4, 10:45 PM
Unknown Object (File)
Feb 17 2025, 2:56 AM
Unknown Object (File)
Feb 17 2025, 1:45 AM
Unknown Object (File)
Jan 27 2025, 1:18 AM
Unknown Object (File)
Jan 24 2025, 11:28 AM
Unknown Object (File)
Jan 23 2025, 7:44 AM
Unknown Object (File)
Jan 21 2025, 6:34 PM

Details

Summary

we were just checking if projects/ was in the URI before barfing. Use some more fun utility functions such that we only complain if there is no project.

Fixes T4071.

Test Plan

made a subpage under a project - success! tried to make a project wiki page where there was no project - successful failure! tried to make a project wiki sub page where there was no project - successful failure!

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Prefer PhabricatorProjectQuery?

btrahan updated this revision to Unknown Object (????).Nov 7 2013, 8:01 PM

prefer the query class. BONUS - prefer it everywhere this little pattern appears