Page MenuHomePhabricator

Phriction - make the check for project sub pages more fine-grained
ClosedPublic

Authored by btrahan on Nov 7 2013, 7:47 PM.
Tags
None
Referenced Files
F13082710: D7527.diff
Wed, Apr 24, 10:15 PM
Unknown Object (File)
Fri, Apr 19, 1:55 PM
Unknown Object (File)
Thu, Apr 11, 8:36 AM
Unknown Object (File)
Wed, Apr 10, 4:25 AM
Unknown Object (File)
Sat, Mar 30, 4:01 PM
Unknown Object (File)
Fri, Mar 29, 1:29 PM
Unknown Object (File)
Feb 10 2024, 2:44 AM
Unknown Object (File)
Feb 6 2024, 5:14 PM

Details

Summary

we were just checking if projects/ was in the URI before barfing. Use some more fun utility functions such that we only complain if there is no project.

Fixes T4071.

Test Plan

made a subpage under a project - success! tried to make a project wiki page where there was no project - successful failure! tried to make a project wiki sub page where there was no project - successful failure!

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Prefer PhabricatorProjectQuery?

btrahan updated this revision to Unknown Object (????).Nov 7 2013, 8:01 PM

prefer the query class. BONUS - prefer it everywhere this little pattern appears