Page MenuHomePhabricator

Phriction - make the check for project sub pages more fine-grained
ClosedPublic

Authored by btrahan on Nov 7 2013, 7:47 PM.
Tags
None
Referenced Files
F18469931: D7527.id.diff
Tue, Sep 2, 5:20 PM
F18462934: D7527.diff
Mon, Sep 1, 11:37 PM
F18092386: D7527.id16974.diff
Aug 7 2025, 9:58 AM
F17948741: D7527.id.diff
Jul 31 2025, 9:56 PM
F17948356: D7527.id16976.diff
Jul 31 2025, 8:50 PM
F17942314: D7527.id16974.diff
Jul 31 2025, 6:38 AM
F17919646: D7527.diff
Jul 30 2025, 2:46 AM
F17911361: D7527.id16975.diff
Jul 29 2025, 3:30 PM

Details

Summary

we were just checking if projects/ was in the URI before barfing. Use some more fun utility functions such that we only complain if there is no project.

Fixes T4071.

Test Plan

made a subpage under a project - success! tried to make a project wiki page where there was no project - successful failure! tried to make a project wiki sub page where there was no project - successful failure!

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Prefer PhabricatorProjectQuery?

btrahan updated this revision to Unknown Object (????).Nov 7 2013, 8:01 PM

prefer the query class. BONUS - prefer it everywhere this little pattern appears