Page MenuHomePhabricator

Fix an issue with pulling Subversion blame data
ClosedPublic

Authored by epriestley on Nov 7 2013, 4:15 PM.
Tags
None
Referenced Files
F18902388: D7523.diff
Sat, Nov 8, 12:59 AM
F18864928: D7523.id.diff
Mon, Nov 3, 9:20 AM
F18864379: D7523.diff
Mon, Nov 3, 5:27 AM
F18808069: D7523.id16977.diff
Sun, Oct 19, 4:47 AM
F18808068: D7523.id16968.diff
Sun, Oct 19, 4:47 AM
F18808067: D7523.id.diff
Sun, Oct 19, 4:47 AM
F18805055: D7523.id.diff
Sat, Oct 18, 1:31 PM
F18735579: D7523.diff
Oct 1 2025, 2:21 AM
Subscribers

Details

Summary

Fixes T4067. The way DiffusionCommitQuery works prevents it from loading SVN identifiers in some cases without additional constraints, since "12345" might be an SVN revision 12345, or it might be the first 5 characters of a Git commit hash.

Introduce withRepository() as a shorthand for withDefaultRepository() + withRepositoryIDs(). This tells the query to:

  • Only look in the given repository; and
  • use the more liberal identifier resolution rules while doing so.

The practical impact this has is that blame tooltips in SVN work again. The other queries which are fixed here were never run in SVN (which doesn't have first-class branches or tags); I've cleaned them up only for completeness.

Test Plan
  • Viewed blame in SVN, saw information again instead of empty tooltip.
  • Viewed brnaches/tags in Mercurial and Git.

{F79226}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped