Page MenuHomePhabricator
Create Task
Maniphest T4067

Blame not working the latest upgrade
Closed, ResolvedPublic
Actions

Description

Blame does not seem to be working in the latest upgrade

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

• andeepak created this task.Nov 6 2013, 9:30 AM
• andeepak assigned this task to epriestley.
• andeepak raised the priority of this task from to Needs Triage.
• andeepak updated the task description. (Show Details)
• andeepak added a project: Phabricator.
• andeepak added a subscriber: • andeepak.
epriestley added a comment.Nov 6 2013, 1:15 PM

Can you reproduce this on secure.phabricator.com? It seems to work fine for me:

Screen_Shot_2013-11-06_at_5.14.24_AM.png (1×1 px, 152 KB)

• andeepak added a comment.Nov 7 2013, 6:12 AM

Just before this upgrade blame used to show the names of folks who had made changes to the code in a column. That column seems to be missing now.

epriestley closed this task as Wontfix.Nov 7 2013, 11:05 AM

We've removed that column because it took up a lot of space, often was particularly useful, and meant less code was visible. You can access the information by hovering over the commit hash. Here, the tooltip shows that I authored the commit:

Screen_Shot_2013-11-07_at_3.03.50_AM.png (931×1 px, 173 KB)

• andeepak added a comment.Nov 7 2013, 3:10 PM

Thats a fair reason, but in our source code here is what I am seeing, previously this worked when you had a column.

Screen_Shot_2013-11-07_at_8.38.25_pm.png (126×1 px, 32 KB)

epriestley reopened this task as Open.Nov 7 2013, 3:16 PM

Ah, thanks for that screenshot. It looks like this issue is specific to SVN -- sorry, I checked a Git repo.

• andeepak added a comment.Nov 7 2013, 3:31 PM

No problem. Thanks for that lightning fast response.

epriestley edited this Maniphest Task.Nov 7 2013, 4:15 PM
epriestley edited this Maniphest Task.Nov 7 2013, 8:11 PM
epriestley closed this task as Resolved.Nov 7 2013, 8:11 PM

Closed by commit rPf68d67530aef.

epriestley added a comment.Nov 7 2013, 8:11 PM

This should be fixed in HEAD. Let us know if it doesn't work or you run into anything else. Thanks for the report!

• andeepak added a comment.Nov 8 2013, 3:13 AM

Cool Thanks!!!

• andeepak added a comment.Nov 8 2013, 4:19 AM

verified, works like charm!!!

Phabricator · Built by Phacility