Index: src/applications/diffusion/controller/DiffusionBranchTableController.php =================================================================== --- src/applications/diffusion/controller/DiffusionBranchTableController.php +++ src/applications/diffusion/controller/DiffusionBranchTableController.php @@ -36,7 +36,7 @@ $commits = id(new DiffusionCommitQuery()) ->setViewer($viewer) ->withIdentifiers(mpull($branches, 'getHeadCommitIdentifier')) - ->withRepositoryIDs(array($repository->getID())) + ->withRepository($repository) ->execute(); $view = id(new DiffusionBranchTableView()) Index: src/applications/diffusion/controller/DiffusionBrowseFileController.php =================================================================== --- src/applications/diffusion/controller/DiffusionBrowseFileController.php +++ src/applications/diffusion/controller/DiffusionBrowseFileController.php @@ -555,7 +555,7 @@ if ($commits) { $commits = id(new DiffusionCommitQuery()) ->setViewer($viewer) - ->withRepositoryIDs(array($drequest->getRepository()->getID())) + ->withRepository($drequest->getRepository()) ->withIdentifiers($commits) ->execute(); $commits = mpull($commits, null, 'getCommitIdentifier'); Index: src/applications/diffusion/controller/DiffusionRepositoryController.php =================================================================== --- src/applications/diffusion/controller/DiffusionRepositoryController.php +++ src/applications/diffusion/controller/DiffusionRepositoryController.php @@ -268,7 +268,7 @@ $commits = id(new DiffusionCommitQuery()) ->setViewer($viewer) ->withIdentifiers(mpull($branches, 'getHeadCommitIdentifier')) - ->withRepositoryIDs(array($drequest->getRepository()->getID())) + ->withRepository($drequest->getRepository()) ->execute(); $table = id(new DiffusionBranchTableView()) @@ -332,7 +332,7 @@ $commits = id(new DiffusionCommitQuery()) ->setViewer($viewer) ->withIdentifiers(mpull($tags, 'getCommitIdentifier')) - ->withRepositoryIDs(array($drequest->getRepository()->getID())) + ->withRepository($drequest->getRepository()) ->needCommitData(true) ->execute(); Index: src/applications/diffusion/controller/DiffusionTagListController.php =================================================================== --- src/applications/diffusion/controller/DiffusionTagListController.php +++ src/applications/diffusion/controller/DiffusionTagListController.php @@ -50,7 +50,7 @@ } else { $commits = id(new DiffusionCommitQuery()) ->setViewer($viewer) - ->withRepositoryIDs(array($repository->getID())) + ->withRepository($repository) ->withIdentifiers(mpull($tags, 'getCommitIdentifier')) ->needCommitData(true) ->execute(); Index: src/applications/diffusion/query/DiffusionCommitQuery.php =================================================================== --- src/applications/diffusion/query/DiffusionCommitQuery.php +++ src/applications/diffusion/query/DiffusionCommitQuery.php @@ -52,6 +52,17 @@ return $this; } + + /** + * Look up commits in a specific repository. This is a shorthand for calling + * @{method:withDefaultRepository} and @{method:withRepositoryIDs}. + */ + public function withRepository(PhabricatorRepository $repository) { + $this->withDefaultRepository($repository); + $this->withRepositoryIDs(array($repository->getID())); + return $this; + } + public function needCommitData($need) { $this->needCommitData = $need; return $this; Index: src/applications/diffusion/query/DiffusionRenameHistoryQuery.php =================================================================== --- src/applications/diffusion/query/DiffusionRenameHistoryQuery.php +++ src/applications/diffusion/query/DiffusionRenameHistoryQuery.php @@ -81,7 +81,7 @@ $commit = id(new DiffusionCommitQuery()) ->setViewer($this->viewer) ->withIdentifiers(array($commit_identifier)) - ->withDefaultRepository($this->request->getRepository()) + ->withRepository($this->request->getRepository()) ->executeOne(); return $commit->getID(); }