Page MenuHomePhabricator

Support ecdsa-sha2-nistp256 SSH keys
ClosedPublic

Authored by epriestley on Nov 7 2013, 2:59 PM.
Tags
None
Referenced Files
F17841727: D7522.id.diff
Sat, Jul 26, 10:47 PM
F17804635: D7522.diff
Fri, Jul 25, 11:38 AM
Unknown Object (File)
Jun 6 2025, 6:03 PM
Unknown Object (File)
May 9 2025, 10:33 PM
Unknown Object (File)
May 8 2025, 7:51 AM
Unknown Object (File)
May 6 2025, 5:03 AM
Unknown Object (File)
May 5 2025, 4:47 PM
Unknown Object (File)
Apr 23 2025, 2:40 PM
Subscribers

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP0e65740c2dfa: Support ecdsa-sha2-nistp256 SSH keys
Summary

See discussion in https://github.com/facebook/phabricator/issues/430.

(If we end up with more than like 5 of these we should probably make this a warning or something instead, the only goal is to prevent user error.)

Test Plan

{F79196}

{F79197}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Looking at the code, maybe it would suffice to test that the array is at least 2 elements long and that the second parameter is a base64 encoded string. The comment by the way is optional.