Page MenuHomePhabricator

Support ecdsa-sha2-nistp256 SSH keys
ClosedPublic

Authored by epriestley on Nov 7 2013, 2:59 PM.
Tags
None
Referenced Files
F13960773: D7522.diff
Tue, Oct 15, 1:18 AM
Unknown Object (File)
Fri, Oct 11, 4:22 AM
Unknown Object (File)
Fri, Oct 11, 4:21 AM
Unknown Object (File)
Fri, Oct 11, 4:21 AM
Unknown Object (File)
Fri, Oct 11, 4:20 AM
Unknown Object (File)
Tue, Oct 8, 7:34 AM
Unknown Object (File)
Sep 17 2024, 4:06 PM
Unknown Object (File)
Sep 17 2024, 2:54 PM
Subscribers

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP0e65740c2dfa: Support ecdsa-sha2-nistp256 SSH keys
Summary

See discussion in https://github.com/facebook/phabricator/issues/430.

(If we end up with more than like 5 of these we should probably make this a warning or something instead, the only goal is to prevent user error.)

Test Plan

{F79196}

{F79197}

Diff Detail

Branch
ecssh
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Looking at the code, maybe it would suffice to test that the array is at least 2 elements long and that the second parameter is a base64 encoded string. The comment by the way is optional.