Page MenuHomePhabricator

Support ecdsa-sha2-nistp256 SSH keys
ClosedPublic

Authored by epriestley on Nov 7 2013, 2:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:11 AM
Unknown Object (File)
Wed, Apr 10, 4:25 AM
Unknown Object (File)
Fri, Apr 5, 11:42 PM
Unknown Object (File)
Fri, Mar 29, 9:52 PM
Unknown Object (File)
Fri, Mar 29, 2:43 AM
Unknown Object (File)
Wed, Mar 20, 10:33 PM
Unknown Object (File)
Wed, Mar 20, 10:33 PM
Unknown Object (File)
Wed, Mar 20, 10:20 PM
Subscribers

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP0e65740c2dfa: Support ecdsa-sha2-nistp256 SSH keys
Summary

See discussion in https://github.com/facebook/phabricator/issues/430.

(If we end up with more than like 5 of these we should probably make this a warning or something instead, the only goal is to prevent user error.)

Test Plan

{F79196}

{F79197}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Looking at the code, maybe it would suffice to test that the array is at least 2 elements long and that the second parameter is a base64 encoded string. The comment by the way is optional.