Page MenuHomePhabricator

Support ecdsa-sha2-nistp256 SSH keys
ClosedPublic

Authored by epriestley on Nov 7 2013, 2:59 PM.
Tags
None
Referenced Files
F15456233: D7522.id.diff
Sun, Mar 30, 8:03 AM
F15441443: D7522.id.diff
Wed, Mar 26, 6:16 PM
F15441442: D7522.id16967.diff
Wed, Mar 26, 6:16 PM
F15441441: D7522.id16973.diff
Wed, Mar 26, 6:15 PM
F15441409: D7522.diff
Wed, Mar 26, 6:03 PM
F15416799: D7522.id.diff
Thu, Mar 20, 1:34 PM
F15387732: D7522.id16973.diff
Sat, Mar 15, 2:49 AM
F15386232: D7522.diff
Sat, Mar 15, 12:12 AM
Subscribers

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP0e65740c2dfa: Support ecdsa-sha2-nistp256 SSH keys
Summary

See discussion in https://github.com/facebook/phabricator/issues/430.

(If we end up with more than like 5 of these we should probably make this a warning or something instead, the only goal is to prevent user error.)

Test Plan

{F79196}

{F79197}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Looking at the code, maybe it would suffice to test that the array is at least 2 elements long and that the second parameter is a base64 encoded string. The comment by the way is optional.