Page MenuHomePhabricator

Support ecdsa-sha2-nistp256 SSH keys
ClosedPublic

Authored by epriestley on Nov 7 2013, 2:59 PM.
Tags
None
Referenced Files
F14023050: D7522.diff
Wed, Nov 6, 10:06 PM
F14001665: D7522.id16973.diff
Fri, Oct 25, 10:48 AM
F13993656: D7522.id16967.diff
Wed, Oct 23, 12:28 AM
F13986236: D7522.id16973.diff
Mon, Oct 21, 1:30 AM
F13974376: D7522.id16967.diff
Oct 18 2024, 5:17 AM
F13960773: D7522.diff
Oct 15 2024, 1:18 AM
Unknown Object (File)
Oct 11 2024, 4:22 AM
Unknown Object (File)
Oct 11 2024, 4:21 AM
Subscribers

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP0e65740c2dfa: Support ecdsa-sha2-nistp256 SSH keys
Summary

See discussion in https://github.com/facebook/phabricator/issues/430.

(If we end up with more than like 5 of these we should probably make this a warning or something instead, the only goal is to prevent user error.)

Test Plan

{F79196}

{F79197}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Looking at the code, maybe it would suffice to test that the array is at least 2 elements long and that the second parameter is a base64 encoded string. The comment by the way is optional.