Differential D7439

Raise a setup warning for missing or invalid local repository directory
ClosedPublic
Actions

Authored by epriestley on Oct 30 2013, 12:03 AM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPf08908ff352f: Raise a setup warning for missing or invalid local repository directory

Summary

I'm planning to add more detailed info to Diffusion itself, but catch the big issue here.

Test Plan

Hit config issue locally, then resolved it.

Diff Detail

Branch

cwarn

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Oct 30 2013, 7:28 PM

btrahan added inline comments.

src/applications/config/check/PhabricatorSetupCheckRepositories.php
19–32	This block got me thinking it would be very nice to tell permissions vs non-existence, but I don't see a way to actually do that after a brief foray into the code. Oh wells.

We do have some code which does it in PhabricatorSetupCheckPath, but it's a lot of code and I think it's hard to generalize the behavior and error messages:

https://secure.phabricator.com/diffusion/P/browse/master/src/applications/config/check/PhabricatorSetupCheckPath.php;90123dd7392f673d$33-95