Page MenuHomePhabricator

Reject SCP-style URIs with explicit protocols in Diffusion
ClosedPublic

Authored by epriestley on Oct 27 2013, 5:36 AM.
Tags
None
Referenced Files
F18574478: D7431.diff
Wed, Sep 10, 10:47 AM
F18505058: D7431.diff
Fri, Sep 5, 12:21 AM
F18113602: D7431.id16758.diff
Wed, Aug 13, 2:41 AM
F18107931: D7431.id.diff
Aug 11 2025, 3:53 AM
F18104907: D7431.diff
Aug 10 2025, 2:56 PM
F17736347: D7431.id16758.diff
Jul 20 2025, 5:00 PM
F17717428: D7431.id16725.diff
Jul 17 2025, 10:52 PM
F17642138: D7431.id16758.diff
Jul 11 2025, 8:20 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc749fcc192f1: Reject SCP-style URIs with explicit protocols in Diffusion
Summary

Fixes T3619. These URIs are valid:

git@domain.com:/path        (Git SCP-style implicit SSH)
ssh://git@domain.com/path   (Explicit SSH)

This URI, arrived at by adding "ssh://" to the front of an SCP-style URI, is not:

ssh://git@domain.com:/path

Detect URIs in this form and reject them. See T3619.

Test Plan

{F75486}

Also set some valid URIs.

Diff Detail

Branch
redit20
Lint
Lint Passed
Unit
No Test Coverage