Reject SCP-style URIs with explicit protocols in Diffusion
ClosedPublic
Actions

Authored by epriestley on Oct 27 2013, 5:36 AM.

Tags

None

Referenced Files

	F13816680: D7431.diff
	Thu, Sep 19, 4:54 PM

	Unknown Object (File)
	Mon, Sep 2, 5:10 AM

	Unknown Object (File)
	Fri, Aug 23, 9:48 PM

	Unknown Object (File)
	Fri, Aug 23, 4:00 PM

	Unknown Object (File)
	Aug 17 2024, 2:05 PM

	Unknown Object (File)
	Aug 16 2024, 11:39 PM

	Unknown Object (File)
	Aug 15 2024, 8:53 PM

	Unknown Object (File)
	Aug 6 2024, 5:07 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rPc749fcc192f1: Reject SCP-style URIs with explicit protocols in Diffusion

Summary

Fixes T3619. These URIs are valid:

git@domain.com:/path        (Git SCP-style implicit SSH)
ssh://git@domain.com/path   (Explicit SSH)

This URI, arrived at by adding "ssh://" to the front of an SCP-style URI, is not:

ssh://git@domain.com:/path

Detect URIs in this form and reject them. See T3619.

Test Plan

{F75486}

Also set some valid URIs.

Diff Detail

Branch

redit20

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Oct 28 2013, 5:21 PM

Closed by commit rPc749fcc192f1 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionRepositoryCreateController.php

15 lines

Diff 16725

View Options

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

Reject SCP-style URIs with explicit protocols in DiffusionClosedPublicActions