Page MenuHomePhabricator

Tie application event listeners to the applications they listen for
ClosedPublic

Authored by epriestley on Oct 19 2013, 9:40 PM.
Tags
None
Referenced Files
F14010451: D7364.diff
Thu, Oct 31, 8:39 AM
F14006731: D7364.diff
Mon, Oct 28, 3:50 PM
F13980550: D7364.id16580.diff
Sat, Oct 19, 11:23 AM
F13980362: D7364.id16609.diff
Sat, Oct 19, 10:09 AM
Unknown Object (File)
Oct 13 2024, 8:48 PM
Unknown Object (File)
Oct 3 2024, 12:21 PM
Unknown Object (File)
Oct 3 2024, 12:15 PM
Unknown Object (File)
Oct 3 2024, 12:14 PM
Subscribers

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPd66972c9f295: Tie application event listeners to the applications they listen for
Summary

Ref T3675. Some of these listeners shouldn't do their thing if the viewer doesn't have access to an application (for example, users without access to Differential should not be able to "Edit Tasks"). Set the stage for that:

  • Introduce PhabricatorEventListener, which has an application.
  • Populate this for event listeners installed by applications.
  • Rename the "PeopleMenu" listeners to "ActionMenu" listeners, which better describes their modern behavior.

This doesn't actually change any behaviors.

Test Plan

Viewed Maniphest, Differntial, People.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped