Paths

Table of Contentst

Differential D7364

Tie application event listeners to the applications they listen for
ClosedPublic
Actions

Authored by epriestley on Oct 19 2013, 9:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 16, 5:51 AM

	Unknown Object (File)
	Mon, Dec 9, 4:18 AM

	Unknown Object (File)
	Mon, Dec 9, 4:18 AM

	Unknown Object (File)
	Mon, Dec 9, 4:18 AM

	Unknown Object (File)
	Mon, Dec 9, 4:18 AM

	Unknown Object (File)
	Sat, Dec 7, 3:10 PM

	Unknown Object (File)
	Fri, Nov 29, 11:17 PM

	Unknown Object (File)
	Fri, Nov 29, 6:17 AM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rPd66972c9f295: Tie application event listeners to the applications they listen for

Summary

Ref T3675. Some of these listeners shouldn't do their thing if the viewer doesn't have access to an application (for example, users without access to Differential should not be able to "Edit Tasks"). Set the stage for that:

Introduce PhabricatorEventListener, which has an application.
Populate this for event listeners installed by applications.
Rename the "PeopleMenu" listeners to "ActionMenu" listeners, which better describes their modern behavior.

This doesn't actually change any behaviors.

Test Plan

Viewed Maniphest, Differntial, People.

Diff Detail

Branch

appevent1

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Oct 21 2013, 11:37 PM

Closed by commit rPd66972c9f295 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

48 lines

aphront/

console/

plugin/

event/

DarkConsoleEventPluginAPI.php

2 lines

applications/

audit/

application/

PhabricatorApplicationAudit.php

2 lines

events/

	AuditActionMenuEventListener.php
	AuditPeopleMenuEventListener.php

2 lines

AuditPeopleMenuEventListener.php

conpherence/

application/

PhabricatorApplicationConpherence.php

2 lines

events/

	ConpherenceActionMenuEventListener.php
	ConpherencePeopleMenuEventListener.php

3 lines

ConpherenceHovercardEventListener.php

2 lines

ConpherencePeopleMenuEventListener.php

daemon/

event/

PhabricatorDaemonEventListener.php

2 lines

differential/

application/

PhabricatorApplicationDifferential.php

2 lines

events/

	DifferentialActionMenuEventListener.php
	DifferentialPeopleMenuEventListener.php

3 lines

DifferentialHovercardEventListener.php

3 lines

DifferentialPeopleMenuEventListener.php

diffusion/

events/

DiffusionHovercardEventListener.php

2 lines

flag/

events/

PhabricatorFlagsUIEventListener.php

2 lines

maniphest/

application/

PhabricatorApplicationManiphest.php

2 lines

event/

	ManiphestActionMenuEventListener.php
	ManiphestPeopleMenuEventListener.php

2 lines

ManiphestEdgeEventListener.php

2 lines

ManiphestHovercardEventListener.php

2 lines

ManiphestNameIndexEventListener.php

2 lines

ManiphestPeopleMenuEventListener.php

people/

event/

PhabricatorPeopleHovercardEventListener.php

2 lines

phrequent/

event/

PhrequentUIEventListener.php

2 lines

phriction/

event/

PhrictionActionMenuEventListener.php

2 lines

subscriptions/

events/

PhabricatorSubscriptionsUIEventListener.php

2 lines

tokens/

event/

PhabricatorTokenUIEventListener.php

2 lines

infrastructure/

events/

PhabricatorEventEngine.php

1 line

PhabricatorEventListener.php

36 lines

PhabricatorExampleEventListener.php

2 lines

Diff 16580

src/__phutil_library_map__.php

Loading...

src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php

Loading...

src/applications/audit/application/PhabricatorApplicationAudit.php

Loading...

src/applications/audit/events/AuditActionMenuEventListener.php

Loading...

src/applications/audit/events/AuditPeopleMenuEventListener.php

Loading...

src/applications/conpherence/application/PhabricatorApplicationConpherence.php

Loading...

src/applications/conpherence/events/ConpherenceActionMenuEventListener.php

Loading...

src/applications/conpherence/events/ConpherenceHovercardEventListener.php

Loading...

src/applications/conpherence/events/ConpherencePeopleMenuEventListener.php

Loading...

src/applications/daemon/event/PhabricatorDaemonEventListener.php

Loading...

src/applications/differential/application/PhabricatorApplicationDifferential.php

Loading...

src/applications/differential/events/DifferentialActionMenuEventListener.php

Loading...

src/applications/differential/events/DifferentialHovercardEventListener.php

Loading...

src/applications/differential/events/DifferentialPeopleMenuEventListener.php

Loading...

src/applications/diffusion/events/DiffusionHovercardEventListener.php

Loading...

src/applications/flag/events/PhabricatorFlagsUIEventListener.php

Loading...

src/applications/maniphest/application/PhabricatorApplicationManiphest.php

Loading...

src/applications/maniphest/event/ManiphestActionMenuEventListener.php

Loading...

src/applications/maniphest/event/ManiphestEdgeEventListener.php

Loading...

src/applications/maniphest/event/ManiphestHovercardEventListener.php

Loading...

src/applications/maniphest/event/ManiphestNameIndexEventListener.php

Loading...

src/applications/maniphest/event/ManiphestPeopleMenuEventListener.php

Loading...

src/applications/people/event/PhabricatorPeopleHovercardEventListener.php

Loading...

src/applications/phrequent/event/PhrequentUIEventListener.php

Loading...

src/applications/phriction/event/PhrictionActionMenuEventListener.php

Loading...

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php

Loading...

src/applications/tokens/event/PhabricatorTokenUIEventListener.php

Loading...

src/infrastructure/events/PhabricatorEventEngine.php

Loading...

src/infrastructure/events/PhabricatorEventListener.php

Loading...

src/infrastructure/events/PhabricatorExampleEventListener.php

Loading...