Page MenuHomePhabricator

Differential Changeset header icons
ClosedPublic

Authored by chad on Oct 15 2013, 6:02 AM.
Tags
None
Referenced Files
F18111044: D7320.diff
Aug 12 2025, 5:48 AM
F17888135: D7320.id16488.diff
Jul 29 2025, 2:00 AM
F17870648: D7320.id.diff
Jul 28 2025, 2:32 PM
F17869098: D7320.id.diff
Jul 28 2025, 10:31 AM
F17680744: D7320.id16487.diff
Jul 13 2025, 4:48 PM
F17672475: D7320.id16492.diff
Jul 13 2025, 3:50 AM
F17650761: D7320.diff
Jul 12 2025, 4:57 AM
Unknown Object (File)
Jun 7 2025, 3:01 AM

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP451dfb9afbb0: Differential Changeset header icons
Summary

Adds filetype icons, applying to differential file headers. The main issue is with all the lightening, I wanted something to still anchor 'new file' on the page and adding a sharp icons does that pretty well for me. Feedback is cool too.

Test Plan

Add some new icons, test in previous commits.

Diff Detail

Branch
diff-headers
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

chad updated this revision to Unknown Object (????).Oct 15 2013, 6:07 AM
  • Missed update

Oh man I love icons.

One thought is that the file tree and Diffusion currently have different icons and maybe we should merge them at some point, but these look good to me.