Page MenuHomePhabricator

Differential Changeset header icons
ClosedPublic

Authored by chad on Oct 15 2013, 6:02 AM.
Tags
None
Referenced Files
F19524452: D7320.id16487.diff
Sun, Jan 18, 1:06 AM
F19303474: D7320.id16492.diff
Dec 24 2025, 1:20 AM
F18877082: D7320.diff
Nov 6 2025, 6:02 AM
F18875504: D7320.id.diff
Nov 5 2025, 6:10 PM
F18867955: D7320.diff
Nov 4 2025, 3:46 AM
F18833898: D7320.id16487.diff
Oct 26 2025, 6:35 AM
F18657859: D7320.diff
Sep 23 2025, 3:45 AM
F18629061: D7320.diff
Sep 16 2025, 7:54 AM

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP451dfb9afbb0: Differential Changeset header icons
Summary

Adds filetype icons, applying to differential file headers. The main issue is with all the lightening, I wanted something to still anchor 'new file' on the page and adding a sharp icons does that pretty well for me. Feedback is cool too.

Test Plan

Add some new icons, test in previous commits.

Diff Detail

Branch
diff-headers
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

chad updated this revision to Unknown Object (????).Oct 15 2013, 6:07 AM
  • Missed update

Oh man I love icons.

One thought is that the file tree and Diffusion currently have different icons and maybe we should merge them at some point, but these look good to me.