Differential D7320

Differential Changeset header icons
ClosedPublic
Actions

Authored by chad on Oct 15 2013, 6:02 AM.

Tags

None

Referenced Files

	F14038206: D7320.id16492.diff
	Sun, Nov 10, 10:08 PM

	F14023523: D7320.id16488.diff
	Thu, Nov 7, 2:34 AM

	F13981986: D7320.id16488.diff
	Sat, Oct 19, 8:30 PM

	F13981823: D7320.id16487.diff
	Sat, Oct 19, 7:19 PM

	F13981822: D7320.diff
	Sat, Oct 19, 7:19 PM

	F13981812: D7320.id.diff
	Sat, Oct 19, 7:16 PM

	F13981797: D7320.id16487.diff
	Sat, Oct 19, 7:08 PM

	F13981794: D7320.id16488.diff
	Sat, Oct 19, 7:06 PM

Subscribers

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP451dfb9afbb0: Differential Changeset header icons

Summary

Adds filetype icons, applying to differential file headers. The main issue is with all the lightening, I wanted something to still anchor 'new file' on the page and adding a sharp icons does that pretty well for me. Feedback is cool too.

Test Plan

Add some new icons, test in previous commits.

Diff Detail

Branch

diff-headers

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

{F69732}

Missed update

Oh man I love icons.

One thought is that the file tree and Diffusion currently have different icons and maybe we should merge them at some point, but these look good to me.

whoops

Closed by commit rP451dfb9afbb0 (authored by @chad).

Revision Contents
Changeset List

Path

Size

resources/

sprite/

icons_1x/

icons_2x/

icons_grey_1x/

icons_grey_2x/

icons_white_1x/

icons_white_2x/

manifest/

90 lines

src/

applications/

differential/

view/

DifferentialChangesetDetailView.php

28 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

6 lines

sprite-icons.css

494 lines

image/

sprite-icons-X2.png

sprite-icons.png

Diff 16487

resources/sprite/icons_1x/calendar.png

Loading...

resources/sprite/icons_1x/data.png

Loading...

resources/sprite/icons_1x/film.png

Loading...

resources/sprite/icons_1x/music.png

Loading...

resources/sprite/icons_1x/wrench.png

Loading...

resources/sprite/icons_1x/zip.png

Loading...

resources/sprite/icons_2x/calendar.png

Loading...

resources/sprite/icons_2x/data.png

Loading...

resources/sprite/icons_2x/film.png

Loading...

resources/sprite/icons_2x/music.png

Loading...

resources/sprite/icons_2x/wrench.png

Loading...

resources/sprite/icons_2x/zip.png

Loading...

resources/sprite/icons_grey_1x/calendar.png

Loading...

resources/sprite/icons_grey_1x/data.png

Loading...

resources/sprite/icons_grey_1x/film.png

Loading...

resources/sprite/icons_grey_1x/music.png

Loading...

resources/sprite/icons_grey_1x/wrench.png

Loading...

resources/sprite/icons_grey_1x/zip.png

Loading...

resources/sprite/icons_grey_2x/calendar.png

Loading...

resources/sprite/icons_grey_2x/data.png

Loading...

resources/sprite/icons_grey_2x/film.png

Loading...

resources/sprite/icons_grey_2x/music.png

Loading...

resources/sprite/icons_grey_2x/wrench.png

Loading...

resources/sprite/icons_grey_2x/zip.png

Loading...

resources/sprite/icons_white_1x/calendar.png

Loading...

resources/sprite/icons_white_1x/data.png

Loading...

resources/sprite/icons_white_1x/film.png

Loading...

resources/sprite/icons_white_1x/music.png

Loading...

resources/sprite/icons_white_1x/wrench.png

Loading...

resources/sprite/icons_white_1x/zip.png

Loading...

resources/sprite/icons_white_2x/calendar.png

Loading...

resources/sprite/icons_white_2x/data.png

Loading...

resources/sprite/icons_white_2x/film.png

Loading...

resources/sprite/icons_white_2x/music.png

Loading...

resources/sprite/icons_white_2x/wrench.png

Loading...

resources/sprite/icons_white_2x/zip.png

Loading...

resources/sprite/manifest/icons.json

Loading...

src/applications/differential/view/DifferentialChangesetDetailView.php

Loading...

webroot/rsrc/css/application/differential/changeset-view.css

Loading...

webroot/rsrc/css/sprite-icons.css

Loading...

webroot/rsrc/image/sprite-icons-X2.png

Loading...

webroot/rsrc/image/sprite-icons.png

Loading...