diff --git a/src/unit/renderer/ArcanistUnitConsoleRenderer.php b/src/unit/renderer/ArcanistUnitConsoleRenderer.php --- a/src/unit/renderer/ArcanistUnitConsoleRenderer.php +++ b/src/unit/renderer/ArcanistUnitConsoleRenderer.php @@ -12,7 +12,7 @@ $test_name = $result->getName(); $test_namespace = $result->getNamespace(); - if (strlen($test_namespace)) { + if (phutil_nonempty_string($test_namespace)) { $test_name = $test_namespace.'::'.$test_name; } @@ -22,7 +22,7 @@ $test_name); if ($result_code != ArcanistUnitTestResult::RESULT_PASS - && strlen($result->getUserData())) { + && phutil_nonempty_string($result->getUserData())) { $return .= $result->getUserData()."\n"; }