Page MenuHomePhabricator

Only attach files that are both referenced in Remarkup and attached by explicit metadata
ClosedPublic

Authored by epriestley on May 20 2022, 5:48 PM.
Tags
None
Referenced Files
F13439641: D21832.diff
Fri, Jul 12, 3:36 AM
F13431490: D21832.id52033.diff
Wed, Jul 10, 8:23 AM
F13414995: D21832.diff
Sun, Jul 7, 5:08 PM
F13410402: D21832.id.diff
Sat, Jul 6, 3:23 PM
F13397421: D21832.diff
Thu, Jul 4, 5:55 AM
F13392777: D21832.id52042.diff
Tue, Jul 2, 5:58 PM
F13374760: D21832.diff
Sat, Jun 29, 12:54 AM
F13372505: D21832.id52042.diff
Fri, Jun 28, 11:26 AM
Subscribers
None

Details

Summary

Ref T13682. When a user uploads a file, then changes their mind and deletes the reference to the file, we don't actually want to attach the file.

When choosing which files to attach, only attach files which are both referenced in Remarkup and explicitly attached in remarkup metadata.

Test Plan
  • Dropped a file into a comment, submitted it, saw it attach normally.
  • Dropped a file into a comment, deleted the reference, submitted it, saw no attachment.

Diff Detail

Repository
rP Phabricator
Branch
file2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25734
Build 35562: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.