Only attach files that are both referenced in Remarkup and attached by explicit metadata
ClosedPublic
Actions

Authored by epriestley on May 20 2022, 5:48 PM.

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rP2a0feb3de0e2: Only attach files that are both referenced in Remarkup and attached by explicit…

Summary

Ref T13682. When a user uploads a file, then changes their mind and deletes the reference to the file, we don't actually want to attach the file.

When choosing which files to attach, only attach files which are both referenced in Remarkup and explicitly attached in remarkup metadata.

Test Plan

Dropped a file into a comment, submitted it, saw it attach normally.
Dropped a file into a comment, deleted the reference, submitted it, saw no attachment.

Repository

rP Phabricator

Branch

file2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25734
Build 35562: arc lint + arc unit

epriestley requested review of this revision.May 20 2022, 5:48 PM

epriestley created this revision.

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

transactions/

editor/

50 lines