Page MenuHomePhabricator

Only attach files that are both referenced in Remarkup and attached by explicit metadata
ClosedPublic

Authored by epriestley on May 20 2022, 5:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 7:05 PM
Unknown Object (File)
Tue, Mar 19, 5:29 PM
Unknown Object (File)
Sat, Mar 16, 12:02 PM
Unknown Object (File)
Tue, Mar 5, 4:45 PM
Unknown Object (File)
Feb 13 2024, 8:33 PM
Unknown Object (File)
Feb 12 2024, 1:01 AM
Unknown Object (File)
Feb 11 2024, 1:50 PM
Unknown Object (File)
Feb 11 2024, 1:50 PM
Subscribers
None

Details

Summary

Ref T13682. When a user uploads a file, then changes their mind and deletes the reference to the file, we don't actually want to attach the file.

When choosing which files to attach, only attach files which are both referenced in Remarkup and explicitly attached in remarkup metadata.

Test Plan
  • Dropped a file into a comment, submitted it, saw it attach normally.
  • Dropped a file into a comment, deleted the reference, submitted it, saw no attachment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.