Differential D21814

Add "pht_list()", a translation wrapper for lists of items
ClosedPublic
Actions

Authored by epriestley on May 12 2022, 5:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 7, 9:52 AM

	Unknown Object (File)
	Tue, May 7, 7:34 AM

	Unknown Object (File)
	Sat, May 4, 10:58 AM

	Unknown Object (File)
	Fri, May 3, 6:54 AM

	Unknown Object (File)
	Wed, May 1, 8:05 PM

	Unknown Object (File)
	Sun, Apr 28, 12:38 PM

	Unknown Object (File)
	Sat, Apr 27, 3:28 PM

	Unknown Object (File)
	Fri, Apr 26, 5:36 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: Restricted Maniphest Task
Commits: rARC3cc486d5c156: Add "pht_list()", a translation wrapper for lists of items

Summary

Ref T13603. This is just a small piece of cleanup I've wanted to do for a while: different languages might have different list separators and repeating this implosion manually all over the place is a bit ugly even if the beahvior is never a function of translation language.

Test Plan

See next change.

Diff Detail

Repository

Branch

list1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25712
Build 35540: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 12 2022, 5:57 PM

epriestley created this revision.

Harbormaster completed remote builds in B25712: Diff 51992.May 12 2022, 5:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 12 2022, 5:57 PM

Closed by commit rARC3cc486d5c156: Add "pht_list()", a translation wrapper for lists of items (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC3cc486d5c156: Add "pht_list()", a translation wrapper for lists of items.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

internationalization/

4 lines

Diff 51992

src/__phutil_library_map__.php

Loading...

src/internationalization/pht.php

Loading...