Page MenuHomePhabricator

Fail in a more comprehensible way when a WorkingCopy lease omits or mangles "repositories.map"
ClosedPublic

Authored by epriestley on May 3 2022, 6:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 23, 12:04 AM
Unknown Object (File)
Mon, Jul 22, 4:50 PM
Unknown Object (File)
Mon, Jul 22, 2:18 PM
Unknown Object (File)
Sat, Jul 20, 7:16 AM
Unknown Object (File)
Wed, Jul 3, 9:41 AM
Unknown Object (File)
Thu, Jun 27, 5:16 AM
Unknown Object (File)
Jun 21 2024, 2:48 PM
Unknown Object (File)
Jun 19 2024, 9:44 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. When the required "repositories.map" attribute is omitted, bin/drydock lease currently fatals in an unhelpful way when trying to lease a working copy.

Test Plan

Ran bin/drydock lease --type working-copy with no attributes, after following steps in T13676.

<Allocation Failed> One or more blueprints promised a new resource, but failed when allocating: [PhutilAggregateException] All blueprints failed to allocate a suitable new resource when trying to allocate lease ("PHID-DRYL-orbtwtlinksm3xqpyhmw").
    - Exception: Working copy lease is missing required attribute "repositories.map".
      
      Attribute "repositories.map" should be a map of repository specifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable