Page MenuHomePhabricator

Fail in a more comprehensible way when a WorkingCopy lease omits or mangles "repositories.map"
ClosedPublic

Authored by epriestley on May 3 2022, 6:36 PM.
Tags
None
Referenced Files
F15453180: D21796.id51965.diff
Sat, Mar 29, 9:59 AM
F15453167: D21796.id.diff
Sat, Mar 29, 9:53 AM
F15439435: D21796.diff
Wed, Mar 26, 7:29 AM
F15391945: D21796.id51965.diff
Sat, Mar 15, 12:27 PM
F15391943: D21796.id51952.diff
Sat, Mar 15, 12:27 PM
F15391942: D21796.id.diff
Sat, Mar 15, 12:27 PM
F15387785: D21796.id51952.diff
Sat, Mar 15, 2:55 AM
F15381236: D21796.id.diff
Fri, Mar 14, 6:36 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. When the required "repositories.map" attribute is omitted, bin/drydock lease currently fatals in an unhelpful way when trying to lease a working copy.

Test Plan

Ran bin/drydock lease --type working-copy with no attributes, after following steps in T13676.

<Allocation Failed> One or more blueprints promised a new resource, but failed when allocating: [PhutilAggregateException] All blueprints failed to allocate a suitable new resource when trying to allocate lease ("PHID-DRYL-orbtwtlinksm3xqpyhmw").
    - Exception: Working copy lease is missing required attribute "repositories.map".
      
      Attribute "repositories.map" should be a map of repository specifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable