Page MenuHomePhabricator

Fail in a more comprehensible way when a WorkingCopy lease omits or mangles "repositories.map"
ClosedPublic

Authored by epriestley on May 3 2022, 6:36 PM.
Tags
None
Referenced Files
F17940714: D21796.id51952.diff
Thu, Jul 31, 4:41 AM
F17869342: D21796.id.diff
Mon, Jul 28, 11:04 AM
F17868707: D21796.id51965.diff
Mon, Jul 28, 8:53 AM
F17849409: D21796.diff
Sun, Jul 27, 8:40 AM
F17844742: D21796.diff
Sun, Jul 27, 2:31 AM
F17674621: D21796.diff
Sun, Jul 13, 7:26 AM
F17657382: D21796.diff
Sat, Jul 12, 12:16 PM
Unknown Object (File)
Jun 30 2025, 9:24 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. When the required "repositories.map" attribute is omitted, bin/drydock lease currently fatals in an unhelpful way when trying to lease a working copy.

Test Plan

Ran bin/drydock lease --type working-copy with no attributes, after following steps in T13676.

<Allocation Failed> One or more blueprints promised a new resource, but failed when allocating: [PhutilAggregateException] All blueprints failed to allocate a suitable new resource when trying to allocate lease ("PHID-DRYL-orbtwtlinksm3xqpyhmw").
    - Exception: Working copy lease is missing required attribute "repositories.map".
      
      Attribute "repositories.map" should be a map of repository specifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable