Page MenuHomePhabricator

Fail in a more comprehensible way when a WorkingCopy lease omits or mangles "repositories.map"
ClosedPublic

Authored by epriestley on May 3 2022, 6:36 PM.
Tags
None
Referenced Files
F13346360: D21796.diff
Fri, Jun 21, 2:48 PM
F13337548: D21796.id.diff
Wed, Jun 19, 9:44 AM
F13333130: D21796.id.diff
Tue, Jun 18, 1:43 AM
F13326849: D21796.diff
Sat, Jun 15, 9:22 AM
F13319575: D21796.diff
Thu, Jun 13, 12:51 PM
F13317368: D21796.diff
Thu, Jun 13, 9:20 AM
F13296205: D21796.diff
Thu, Jun 6, 12:19 PM
F13278793: D21796.id51965.diff
Sat, Jun 1, 5:02 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. When the required "repositories.map" attribute is omitted, bin/drydock lease currently fatals in an unhelpful way when trying to lease a working copy.

Test Plan

Ran bin/drydock lease --type working-copy with no attributes, after following steps in T13676.

<Allocation Failed> One or more blueprints promised a new resource, but failed when allocating: [PhutilAggregateException] All blueprints failed to allocate a suitable new resource when trying to allocate lease ("PHID-DRYL-orbtwtlinksm3xqpyhmw").
    - Exception: Working copy lease is missing required attribute "repositories.map".
      
      Attribute "repositories.map" should be a map of repository specifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable