Page MenuHomePhabricator

Fail in a more comprehensible way when a WorkingCopy lease omits or mangles "repositories.map"
ClosedPublic

Authored by epriestley on May 3 2022, 6:36 PM.
Tags
None
Referenced Files
F18877174: D21796.diff
Thu, Nov 6, 6:40 AM
F18856903: D21796.diff
Sat, Nov 1, 12:05 PM
F18855505: D21796.diff
Sat, Nov 1, 5:27 AM
F18787400: D21796.diff
Oct 14 2025, 11:35 PM
F18777808: D21796.id.diff
Oct 11 2025, 5:36 AM
F18741263: D21796.id.diff
Oct 2 2025, 9:58 AM
F18736922: D21796.diff
Oct 1 2025, 8:16 AM
F18592294: D21796.id.diff
Sep 12 2025, 11:54 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. When the required "repositories.map" attribute is omitted, bin/drydock lease currently fatals in an unhelpful way when trying to lease a working copy.

Test Plan

Ran bin/drydock lease --type working-copy with no attributes, after following steps in T13676.

<Allocation Failed> One or more blueprints promised a new resource, but failed when allocating: [PhutilAggregateException] All blueprints failed to allocate a suitable new resource when trying to allocate lease ("PHID-DRYL-orbtwtlinksm3xqpyhmw").
    - Exception: Working copy lease is missing required attribute "repositories.map".
      
      Attribute "repositories.map" should be a map of repository specifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable