Page MenuHomePhabricator

Fail in a more comprehensible way when a WorkingCopy lease omits or mangles "repositories.map"
ClosedPublic

Authored by epriestley on May 3 2022, 6:36 PM.
Tags
None
Referenced Files
F19503300: D21796.id51965.diff
Thu, Jan 8, 10:45 PM
F19487846: D21796.diff
Thu, Jan 8, 4:35 AM
F19487845: D21796.diff
Thu, Jan 8, 4:35 AM
F19487729: D21796.diff
Thu, Jan 8, 4:29 AM
F19487644: D21796.diff
Thu, Jan 8, 4:23 AM
F19487629: D21796.diff
Thu, Jan 8, 4:23 AM
F19487624: D21796.diff
Thu, Jan 8, 4:22 AM
F19486465: D21796.diff
Thu, Jan 8, 3:50 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. When the required "repositories.map" attribute is omitted, bin/drydock lease currently fatals in an unhelpful way when trying to lease a working copy.

Test Plan

Ran bin/drydock lease --type working-copy with no attributes, after following steps in T13676.

<Allocation Failed> One or more blueprints promised a new resource, but failed when allocating: [PhutilAggregateException] All blueprints failed to allocate a suitable new resource when trying to allocate lease ("PHID-DRYL-orbtwtlinksm3xqpyhmw").
    - Exception: Working copy lease is missing required attribute "repositories.map".
      
      Attribute "repositories.map" should be a map of repository specifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable