Page MenuHomePhabricator

Catch more product names in "pht()", and replace newly matched Arcanist product names
ClosedPublic

Authored by epriestley on Apr 25 2022, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 25, 7:23 PM
Unknown Object (File)
Thu, Jun 16, 10:11 AM
Unknown Object (File)
Thu, Jun 16, 10:11 AM
Unknown Object (File)
Thu, Jun 16, 10:11 AM
Unknown Object (File)
Mon, Jun 13, 1:34 PM
Unknown Object (File)
Sat, Jun 11, 11:46 AM
Unknown Object (File)
Thu, Jun 9, 7:08 AM
Unknown Object (File)
Mon, Jun 6, 11:58 AM
Subscribers
None

Details

Summary

Ref T13658. The lint rule called "getStringLiteralValue()", which produces string literals for fewer nodes than "evalStatic()".

Switch to "evalStatic()", then fix new warnings.

Test Plan

This test plan is non-exhaustive.

  • Ran "arc lint --everything --output summary" to generate new warnings.

Diff Detail

Repository
rARC Arcanist
Branch
product11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25669
Build 35497: arc lint + arc unit

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 11:46 PM
This revision was automatically updated to reflect the committed changes.