Fix a PHP 8.1 string strictness issue in repositories
ClosedPublic
Actions

Authored by epriestley on Apr 25 2022, 7:28 PM.

Tags

None

Referenced Files

	F20966542: D21775.diff
	Sun, Jun 28, 1:08 PM

	Unknown Object (File)
	Wed, Jun 24, 7:06 AM

	Unknown Object (File)
	Fri, Jun 19, 7:45 PM

	Unknown Object (File)
	Thu, Jun 18, 12:25 AM

	Unknown Object (File)
	Thu, Jun 4, 2:01 PM

	Unknown Object (File)
	Tue, Jun 2, 11:19 AM

	Unknown Object (File)
	Apr 15 2026, 10:32 AM

	Unknown Object (File)
	Apr 3 2026, 2:38 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rPadcc063242e5: Fix a PHP 8.1 string strictness issue in repositories

Summary

Ref T13588. This is a little too strict, as $line may be an integer.

Test Plan

Will deploy

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.Apr 25 2022, 7:28 PM

epriestley created this revision.

Harbormaster completed remote builds in B25668: Diff 51911.Apr 25 2022, 7:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:30 PM

Closed by commit rPadcc063242e5: Fix a PHP 8.1 string strictness issue in repositories (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPadcc063242e5: Fix a PHP 8.1 string strictness issue in repositories.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

1 line

Diff 51912

View Options

src/applications/repository/storage/PhabricatorRepository.php

Fix a PHP 8.1 string strictness issue in repositoriesClosedPublicActions