Paths

Table of Contentst

Fix a PHP 8.1 string strictness issue in repositories
ClosedPublic
Actions

Authored by epriestley on Apr 25 2022, 7:28 PM.

Tags

None

Referenced Files

	F15502885: D21775.diff
	Mon, Apr 14, 5:19 AM

	F15491463: D21775.id51912.diff
	Sat, Apr 12, 3:49 AM

	F15489759: D21775.id.diff
	Fri, Apr 11, 12:03 PM

	F15486511: D21775.diff
	Thu, Apr 10, 7:56 AM

	F15454926: D21775.id51912.diff
	Sat, Mar 29, 9:19 PM

	F15454910: D21775.id51911.diff
	Sat, Mar 29, 9:15 PM

	F15454900: D21775.id.diff
	Sat, Mar 29, 9:10 PM

	F15439602: D21775.diff
	Wed, Mar 26, 8:13 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rPadcc063242e5: Fix a PHP 8.1 string strictness issue in repositories

Summary

Ref T13588. This is a little too strict, as $line may be an integer.

Test Plan

Will deploy

Diff Detail

Repository

rP Phabricator

Branch

string1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25668
Build 35496: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Apr 25 2022, 7:28 PM

epriestley created this revision.

Harbormaster completed remote builds in B25668: Diff 51911.Apr 25 2022, 7:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:30 PM

Closed by commit rPadcc063242e5: Fix a PHP 8.1 string strictness issue in repositories (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPadcc063242e5: Fix a PHP 8.1 string strictness issue in repositories.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

1 line

Diff 51911

View Options

src/applications/repository/storage/PhabricatorRepository.php

Fix a PHP 8.1 string strictness issue in repositoriesClosedPublicActions