Page MenuHomePhabricator
Differential D21748

Make Phame blog policies non-nullable
ClosedPublic
Actions

Authored by epriestley on Apr 1 2022, 6:42 PM.
Tags
None
Referenced Files
F15545844: D21748.id.diff
Sat, Apr 26, 1:08 PM
F15531850: D21748.diff
Wed, Apr 23, 1:24 PM
F15483745: D21748.id51846.diff
Wed, Apr 9, 2:08 PM
F15470271: D21748.id51855.diff
Fri, Apr 4, 9:28 PM
F15454437: D21748.id51855.diff
Mar 29 2025, 6:32 PM
F15440734: D21748.id.diff
Mar 26 2025, 2:20 PM
F15438774: D21748.id51846.diff
Mar 26 2025, 3:33 AM
F15437969: D21748.id51846.diff
Mar 25 2025, 10:24 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T6203: Adjust nullability of various questionable columns
T13661: Give Phame configurable interact policies
Commits
rP28b12fb3cdaf: Make Phame blog policies non-nullable
Summary

Ref T6203. Ref T13661. These policies are incorrectly nullable, although it's likely that no pathway exists in the application to write NULL into them. Fix the schema.

Test Plan

Ran bin/storage upgrade.

Diff Detail

Repository
rP Phabricator
Branch
phameint1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25631
Build 35459: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 1 2022, 6:42 PM
Owners added a subscriber: Restricted Owners Package.Apr 1 2022, 6:42 PM
epriestley requested review of this revision.Apr 1 2022, 6:42 PM
Harbormaster completed remote builds in B25631: Diff 51846.Apr 1 2022, 6:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2022, 7:53 PM
Closed by commit rP28b12fb3cdaf: Make Phame blog policies non-nullable (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP28b12fb3cdaf: Make Phame blog policies non-nullable.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
5 lines
5 lines
src/
applications/
phame/
storage/
6 lines

Diff 51846

View Options

resources/sql/autopatches/20220401.phameinteract.01.sql

Loading...
View Options

resources/sql/autopatches/20220401.phameinteract.02.sql

Loading...
View Options

src/applications/phame/storage/PhameBlog.php

Loading...
Phabricator · Built by Phacility