Page MenuHomePhabricator
Differential D21741

Add a lint rule forbidding use of "each()"
ClosedPublic
Actions

Authored by epriestley on Dec 9 2021, 9:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 4:15 AM
Unknown Object (File)
Wed, Nov 13, 9:08 PM
Unknown Object (File)
Tue, Nov 12, 11:38 AM
Unknown Object (File)
Sun, Nov 10, 3:28 PM
Unknown Object (File)
Sat, Nov 9, 4:50 PM
Unknown Object (File)
Fri, Nov 8, 3:19 AM
Unknown Object (File)
Thu, Nov 7, 3:42 AM
Unknown Object (File)
Tue, Nov 5, 7:47 PM
View All Files
Subscribers
cspeckmim

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rARC488f13a60e88: Add a lint rule forbidding use of "each()"
Summary

Ref T13588. "each()" has been a bad idea for a long time, and was formally deprecated in PHP 7.2 and removed in PHP 8.0.

Catch use of "each()" in lint and reject it.

Test Plan

Added and ran unit tests.

Screen Shot 2021-12-09 at 1.53.30 PM.png (201×586 px, 62 KB)

Diff Detail

Repository
rARC Arcanist
Branch
each1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25601
Build 35412: Run Core Tests
Build 35411: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 9 2021, 9:55 PM
Harbormaster completed remote builds in B25601: Diff 51813.Dec 9 2021, 9:55 PM
epriestley requested review of this revision.Dec 9 2021, 9:55 PM
cspeckmim added a subscriber: cspeckmim.Dec 9 2021, 10:08 PM

... and was formally deprecated in PHP 7.4 and removed in PHP 8.0.

The lint emitted says 7.2 (which appears to be correct), a minor inconsistency in the revision description

epriestley edited the summary of this revision. (Show Details)Dec 9 2021, 10:10 PM

Ah, yep, should be 7.2 -- thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 11:59 PM
Closed by commit rARC488f13a60e88: Add a lint rule forbidding use of "each()" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC488f13a60e88: Add a lint rule forbidding use of "each()".

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
xhpast/
rules/
24 lines
__tests__/
10 lines
each-use/
6 lines

Diff 51813

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistEachUseXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistEachUseXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/each-use/each.lint-test

Loading...
Phabricator · Built by Phacility