Differential D21711

Name extension as "arc-hg", not "arg-hg"
ClosedPublic
Actions

Authored by epriestley on Jul 26 2021, 6:49 PM.

Details

Reviewers

cspeckmim

Maniphest Tasks

T13659: `arc land` may fail with missing rebase extension

Commits

rARC82016c00e132: Name extension as "arc-hg", not "arg-hg"

Summary

Ref T13659. I don't think this name actually matters since Mercurial doesn't care what the extension name is, but be a little more consistent.

Test Plan

Ran "arc land ..." and saw it run "arc-hg" commands. There's no behavioral change here: Mercurial loads the extension and runs fine no matter what name we provide.

Diff Detail

Repository

rARC Arcanist

Branch

extname1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25521
Build 35285: Run Core Tests
Build 35284: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 26 2021, 6:49 PM

Harbormaster completed remote builds in B25521: Diff 51718.Jul 26 2021, 6:49 PM

epriestley requested review of this revision.Jul 26 2021, 6:49 PM

epriestley mentioned this in T13659: `arc land` may fail with missing rebase extension.Jul 26 2021, 6:49 PM

argh

This revision is now accepted and ready to land.Jul 26 2021, 6:52 PM

Closed by commit rARC82016c00e132: Name extension as "arc-hg", not "arg-hg" (authored by epriestley). · Explain WhyJul 26 2021, 7:27 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC82016c00e132: Name extension as "arc-hg", not "arg-hg".

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistMercurialAPI.php

2 lines

Diff 51718

View Options

src/repository/api/ArcanistMercurialAPI.php

Name extension as "arc-hg", not "arg-hg"ClosedPublicActions