Page MenuHomePhabricator

Resolve deleted packages properly as having no mailable members

Authored by epriestley on Jul 21 2021, 9:22 PM.
Referenced Files
F12185969: D21707.diff
Sat, Sep 16, 3:56 PM
F12174461: D21707.diff
Sat, Sep 9, 12:12 PM
F12134298: D21707.diff
Aug 25 2023, 4:25 AM
Unknown Object (File)
Aug 6 2023, 4:19 PM
Unknown Object (File)
Aug 6 2023, 4:16 PM
Unknown Object (File)
Aug 6 2023, 4:15 PM
Unknown Object (File)
Jul 24 2023, 3:40 AM
Unknown Object (File)
Jul 22 2023, 12:00 AM



Fixes T13648. If a package recipient has been destroyed, this query currently fails to return an expanded recipient value.

Instead, make sure all input PHIDs get an output. For destroyed packages, the output will just be an empty list.

Test Plan
  • Added a package to a revision as a reviewer.
  • Destroyed the package.
  • Commented on the revision.
  • Processed the publishing worker with bin/worker execute.
  • Before: fatal after expanding the destroyed package.
  • After: clean publish.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:50 PM
This revision was automatically updated to reflect the committed changes.