Differential D21693

Remove "HarbormasterBuildableTransaction::TYPE_CREATE"
ClosedPublic
Actions

Authored by epriestley on Jul 16 2021, 3:34 PM.

Details

Reviewers: None
Maniphest Tasks: T13072: Merge Harbormaster BuildCommand into BuildMessage
Commits: rP706b91adf677: Remove "HarbormasterBuildableTransaction::TYPE_CREATE"

Summary

Ref T13072. This transaction type has no writers and is mooted by EditEngine.

Test Plan

Grepped for transaction constant.

Diff Detail

Repository

rP Phabricator

Branch

build10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25459
Build 35186: Run Core Tests
Build 35185: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 16 2021, 3:34 PM

Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 3:34 PM

Harbormaster completed remote builds in B25459: Diff 51656.Jul 16 2021, 3:35 PM

epriestley requested review of this revision.Jul 16 2021, 3:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM

Closed by commit rP706b91adf677: Remove "HarbormasterBuildableTransaction::TYPE_CREATE" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP706b91adf677: Remove "HarbormasterBuildableTransaction::TYPE_CREATE".

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

editor/

HarbormasterBuildableTransactionEditor.php

6 lines

storage/

HarbormasterBuildableTransaction.php

9 lines

Diff 51656

View Options

src/applications/harbormaster/editor/HarbormasterBuildableTransactionEditor.php