Page MenuHomePhabricator
Differential D21692

Remove "HarbormasterBuildCommand"
ClosedPublic
Actions

Authored by epriestley on Jul 16 2021, 3:10 PM.
Tags
None
Referenced Files
F18788961: D21692.diff
Wed, Oct 15, 7:17 AM
F18787796: D21692.id51655.diff
Wed, Oct 15, 1:35 AM
F18781056: D21692.id.diff
Sun, Oct 12, 9:10 PM
F18734436: D21692.id.diff
Tue, Sep 30, 10:54 PM
F18646850: D21692.id.diff
Fri, Sep 19, 11:18 AM
F18629783: D21692.diff
Tue, Sep 16, 9:52 AM
F18619604: D21692.id.diff
Sep 15 2025, 2:54 AM
F18596400: D21692.id51655.diff
Sep 13 2025, 12:36 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13072: Merge Harbormaster BuildCommand into BuildMessage
Commits
rP1a1395579f95: Remove "HarbormasterBuildCommand"
Summary

Ref T13072. Update the last few constant references to this class and remove it.

Test Plan

Grepped for "HarbormasterBuildCommand", got no hits.

Diff Detail

Repository
rP Phabricator
Branch
build9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25458
Build 35184: Run Core Tests
Build 35183: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 16 2021, 3:10 PM
Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 3:10 PM
Harbormaster completed remote builds in B25458: Diff 51655.Jul 16 2021, 3:11 PM
epriestley requested review of this revision.Jul 16 2021, 3:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
Closed by commit rP1a1395579f95: Remove "HarbormasterBuildCommand" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP1a1395579f95: Remove "HarbormasterBuildCommand".

Revision Contents
Changeset List

Diff 51655

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterAbortOlderBuildsBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildCommand.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
Phabricator · Built by Phacility