Page MenuHomePhabricator
Differential D21683

Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages" table
ClosedPublic
Actions

Authored by epriestley on Jul 13 2021, 10:23 PM.
Tags
None
Referenced Files
F18106549: D21683.diff
Sun, Aug 10, 11:08 PM
F18026849: D21683.diff
Sat, Aug 2, 10:16 PM
F17952947: D21683.id51644.diff
Fri, Aug 1, 2:35 AM
F17913410: D21683.diff
Tue, Jul 29, 5:48 PM
Unknown Object (File)
Jul 3 2025, 10:36 AM
Unknown Object (File)
Jun 4 2025, 2:11 PM
Unknown Object (File)
May 28 2025, 10:26 AM
Unknown Object (File)
May 27 2025, 9:41 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13072: Merge Harbormaster BuildCommand into BuildMessage
Commits
rP0f93d1ffe450: Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages"…
Summary

Ref T13072. Rename various "command" properties to "message" properties, to prepare for merging "HarbormasterCommand" into "HarbormasterMessage".

This change only renames variables and methods and should not affect program behavior.

Test Plan

Grepped for affected symbols, found no unmodified hits.

Diff Detail

Repository
rP Phabricator
Branch
build1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/harbormaster/storage/build/HarbormasterBuild.php:402XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 25447
Build 35162: Run Core Tests
Build 35161: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 13 2021, 10:23 PM
Owners added a subscriber: Restricted Owners Package.Jul 13 2021, 10:23 PM
Harbormaster completed remote builds in B25447: Diff 51644.Jul 13 2021, 10:24 PM
epriestley requested review of this revision.Jul 13 2021, 10:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
Closed by commit rP0f93d1ffe450: Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages"… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP0f93d1ffe450: Rename "HarbormasterBuild" methods to prepare for use of the "BuildMessages"….

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
engine/
2 lines
query/
8 lines
storage/
build/
56 lines

Diff 51644

View Options

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildQuery.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
Phabricator · Built by Phacility