Differential D21678

Remove some "Phacility" and "epriestley" references
ClosedPublic
Actions

Authored by epriestley on Jun 30 2021, 10:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 10:18 AM

	Unknown Object (File)
	Mon, Apr 8, 3:48 AM

	Unknown Object (File)
	Sat, Apr 6, 9:18 AM

	Unknown Object (File)
	Sun, Mar 31, 5:19 PM

	Unknown Object (File)
	Sat, Mar 30, 10:07 AM

	Unknown Object (File)
	Thu, Mar 28, 11:17 AM

	Unknown Object (File)
	Thu, Mar 28, 10:33 AM

	Unknown Object (File)
	Mar 1 2024, 7:43 PM

Subscribers

Restricted Owners Package

Details

Reviewers

Maniphest Tasks

T13658: How to rebrand Phabricator

Commits

rP5521f76fe406: Remove some "Phacility" and "epriestley" references

Summary

Ref T13658. This just scrubs some of the simple references from the codebase.

Most of what's left is in documentation which won't be relevant for a fork and/or which I need to separately revise (or more-or-less delete) at some point anyway.

I removed the "install RHEL" and "install Ubuntu" scripts outright since I don't have any reasonable way to test them and don't plan to maintain them.

Test Plan

Grepped for "phacility", "epriestley"; ran unit tests.

Diff Detail

Repository

Branch

phacility1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25405
Build 35084: Run Core Tests
Build 35083: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 30 2021, 10:31 PM

Owners added a subscriber: Restricted Owners Package.Jun 30 2021, 10:31 PM

Harbormaster completed remote builds in B25405: Diff 51601.Jun 30 2021, 10:32 PM

epriestley requested review of this revision.Jun 30 2021, 10:32 PM

I removed the "install RHEL" and "install Ubuntu" scripts outright since I don't have any reasonable way to test them and don't plan to maintain them.

Ah I did come across these as well and forgot to note.

src/applications/calendar/parser/ics/PhutilICSWriter.php
131	Oh I hadn't gotten to the calendar application yet, I'll have to learn about the ICS format/protocol 😬
src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php
23	:)

This revision is now accepted and ready to land.Jul 1 2021, 1:47 AM

Closed by commit rP5521f76fe406: Remove some "Phacility" and "epriestley" references (authored by epriestley). · Explain WhyJul 8 2021, 5:46 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5521f76fe406: Remove some "Phacility" and "epriestley" references.

Revision Contents
Changeset List

Path

Size

2 lines

resources/

celerity/

sql/

patches/

20131004.dxreviewers.php

3 lines

scripts/

install/

install_rhel-derivs.sh

install_ubuntu.sh

src/

applications/

almanac/

util/

__tests__/

AlmanacNamesTestCase.php

2 lines

base/

PhabricatorApplication.php

5 lines

calendar/

parser/

ics/

PhutilICSWriter.php

6 lines

__tests__/

PhutilICSWriterTestCase.php

6 lines

data/

writer-christmas.ics

2 lines

writer-office-party.ics

2 lines

writer-recurring-christmas.ics

2 lines

writer-tea-time.ics

2 lines

metamta/

parser/

PhabricatorMetaMTAEmailBodyParser.php

6 lines

repository/

engine/

PhabricatorRepositoryPullEngine.php

1 line

uiexample/

examples/

PHUIBadgeExample.php

4 lines

docs/

user/

installation_guide.diviner

17 lines

userguide/

5 lines

webroot/

rsrc/

externals/

javelin/

lib/

4 lines

Diff 51601

NOTICE

Loading...

resources/celerity/map.php

Loading...

resources/sql/patches/20131004.dxreviewers.php

Loading...

scripts/install/install_rhel-derivs.sh

Loading...

scripts/install/install_ubuntu.sh

Loading...

src/applications/almanac/util/tests/AlmanacNamesTestCase.php

Loading...

src/applications/base/PhabricatorApplication.php

Loading...

src/applications/calendar/parser/ics/PhutilICSWriter.php

Loading...

src/applications/calendar/parser/ics/tests/PhutilICSWriterTestCase.php

Loading...

src/applications/calendar/parser/ics/tests/data/writer-christmas.ics

Loading...

src/applications/calendar/parser/ics/tests/data/writer-office-party.ics

Loading...

src/applications/calendar/parser/ics/tests/data/writer-recurring-christmas.ics

Loading...

src/applications/calendar/parser/ics/tests/data/writer-tea-time.ics

Loading...

src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php

Loading...

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...

src/applications/uiexample/examples/PHUIBadgeExample.php

Loading...

src/docs/user/installation_guide.diviner

Loading...

src/docs/user/userguide/phame.diviner

Loading...

webroot/rsrc/externals/javelin/lib/DOM.js

Loading...