Page MenuHomePhabricator
Differential D21645

Make inline "ContentState" a client object, and track "hasSuggestion" on it
ClosedPublic
Actions

Authored by epriestley on Mar 25 2021, 8:51 PM.
Tags
None
Referenced Files
F15438841: D21645.id51513.diff
Wed, Mar 26, 3:55 AM
F15436692: D21645.id.diff
Tue, Mar 25, 3:58 PM
F15431543: D21645.diff
Mon, Mar 24, 12:59 PM
F15402769: D21645.id51539.diff
Tue, Mar 18, 12:16 AM
F15382931: D21645.diff
Fri, Mar 14, 2:58 PM
Unknown Object (File)
Wed, Feb 26, 5:34 PM
Unknown Object (File)
Feb 24 2025, 8:19 AM
Unknown Object (File)
Feb 22 2025, 12:20 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting
Commits
rPb964731b6a6b: Make inline "ContentState" a client object, and track "hasSuggestion" on it
Summary

Ref T13559. In an effort to ultimately fix the "quote + cancel" bug, begin formalizing content states on the client.

This creates a "ContentState" client object and moves the authoritative storage for the "hasSuggestion" property to it.

Test Plan

Created inlines, etc. See followups.

Diff Detail

Repository
rP Phabricator
Branch
istate2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25321
Build 34957: Run Core Tests
Build 34956: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 25 2021, 8:51 PM
Harbormaster completed remote builds in B25321: Diff 51513.Mar 25 2021, 8:52 PM
epriestley requested review of this revision.Mar 25 2021, 8:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
Closed by commit rPb964731b6a6b: Make inline "ContentState" a client object, and track "hasSuggestion" on it (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPb964731b6a6b: Make inline "ContentState" a client object, and track "hasSuggestion" on it.

Revision Contents
Changeset List

PathSize
resources/
celerity/
1 line
webroot/
rsrc/
js/
application/
diff/
15 lines
22 lines

Diff 51513

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInlineContentState.js

Loading...
Phabricator · Built by Phacility