Page MenuHomePhabricator

Make inline "ContentState" a client object, and track "hasSuggestion" on it
ClosedPublic

Authored by epriestley on Mar 25 2021, 8:51 PM.

Details

Summary

Ref T13559. In an effort to ultimately fix the "quote + cancel" bug, begin formalizing content states on the client.

This creates a "ContentState" client object and moves the authoritative storage for the "hasSuggestion" property to it.

Test Plan

Created inlines, etc. See followups.

Diff Detail

Repository
rP Phabricator
Branch
istate2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25321
Build 34957: Run Core Tests
Build 34956: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
This revision was automatically updated to reflect the committed changes.