Page MenuHomePhabricator

Make inline "ContentState" a client object, and track "hasSuggestion" on it
ClosedPublic

Authored by epriestley on Mar 25 2021, 8:51 PM.
Tags
None
Referenced Files
F12818916: D21645.id.diff
Thu, Mar 28, 5:13 AM
F12808381: D21645.id51513.diff
Wed, Mar 27, 8:31 PM
Unknown Object (File)
Feb 21 2024, 6:27 AM
Unknown Object (File)
Feb 21 2024, 6:27 AM
Unknown Object (File)
Feb 21 2024, 6:27 AM
Unknown Object (File)
Feb 4 2024, 12:55 AM
Unknown Object (File)
Jan 22 2024, 10:10 AM
Unknown Object (File)
Jan 18 2024, 7:23 AM
Subscribers
None

Details

Summary

Ref T13559. In an effort to ultimately fix the "quote + cancel" bug, begin formalizing content states on the client.

This creates a "ContentState" client object and moves the authoritative storage for the "hasSuggestion" property to it.

Test Plan

Created inlines, etc. See followups.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
This revision was automatically updated to reflect the committed changes.