Page MenuHomePhabricator

Fix an error when users receive notifications about objects they can no longer see
ClosedPublic

Authored by epriestley on Mar 11 2021, 6:34 PM.
Tags
None
Referenced Files
F15383431: D21603.id51430.diff
Fri, Mar 14, 4:41 PM
F15284681: D21603.diff
Tue, Mar 4, 10:18 AM
Unknown Object (File)
Fri, Feb 21, 6:05 PM
Unknown Object (File)
Wed, Feb 19, 11:40 PM
Unknown Object (File)
Wed, Feb 19, 11:40 PM
Unknown Object (File)
Wed, Feb 19, 11:40 PM
Unknown Object (File)
Wed, Feb 19, 7:44 PM
Unknown Object (File)
Mon, Feb 17, 11:26 PM
Subscribers
None

Details

Summary

Ref T13623. The change in D21577 could lead to a case where we try to access stories the user can't see.

Move the story-loading piece to "willFilterPage()" to make our way thorugh this.

Test Plan
  • Made FeedStory return nothing to simulate invisible notifications, loaded page.
    • Before: index access fatal.
    • After: clean "no notifications".
  • Loaded notifications normally, saw normal notifications.

Diff Detail

Repository
rP Phabricator
Branch
notif1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25236
Build 34829: Run Core Tests
Build 34828: arc lint + arc unit