Differential D21603

Fix an error when users receive notifications about objects they can no longer see
ClosedPublic
Actions

Authored by epriestley on Mar 11 2021, 6:34 PM.

Details

Reviewers: None
Maniphest Tasks: T13623: Notifications may fail to paginate with GROUP BY error
Commits: rP0815891e4263: Fix an error when users receive notifications about objects they can no longer…

Summary

Ref T13623. The change in D21577 could lead to a case where we try to access stories the user can't see.

Move the story-loading piece to "willFilterPage()" to make our way thorugh this.

Test Plan

Made FeedStory return nothing to simulate invisible notifications, loaded page.
- Before: index access fatal.
- After: clean "no notifications".
Loaded notifications normally, saw normal notifications.

Diff Detail

Repository

rP Phabricator

Branch

notif1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25236
Build 34829: Run Core Tests
Build 34828: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 11 2021, 6:34 PM

Harbormaster completed remote builds in B25236: Diff 51429.Mar 11 2021, 6:35 PM

epriestley requested review of this revision.Mar 11 2021, 6:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 6:44 PM

Closed by commit rP0815891e4263: Fix an error when users receive notifications about objects they can no longer… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0815891e4263: Fix an error when users receive notifications about objects they can no longer….

epriestley mentioned this in D21609: Fix a followup notification paging error with partial objects.Mar 12 2021, 5:08 PM

epriestley mentioned this in rP4b529e600928: Fix a followup notification paging error with partial objects.Mar 12 2021, 5:09 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

notification/

query/

PhabricatorNotificationQuery.php

61 lines

Diff 51429

View Options

src/applications/notification/query/PhabricatorNotificationQuery.php

Fix an error when users receive notifications about objects they can no longer seeClosedPublicActions