Diffusion Phabricator 4cff4dc68b6e

Interpret search tokens in the for "_..." as substring search
4cff4dc68b6e
Actions

Description

Interpret search tokens in the for "_..." as substring search

Summary: Ref T13632. Users searching for __FILE__, etc., almost certainly mean to perform a substring search.

Test Plan: Added tests and made them pass. Searched for various tokens, saw compiler interpretation in UI.

Maniphest Tasks: T13632

Differential Revision: https://secure.phabricator.com/D21602

Details

Provenance

epriestley	Authored on Mar 10 2021, 7:43 PM
epriestley	Pushed on Mar 10 2021, 8:00 PM

Differential Revision

D21602: Interpret search tokens in the for "_..." as substring search

Parents

rPafdef332fb20: Allow "transaction.search" to be called on an object type

Branches

Unknown

Tags

Unknown

Tasks

T13632: Compile `_...` search tokens as substring searches

Build Status

Buildable 25235
Build 34827: Run Core Tests

Event Timeline

epriestley committed rP4cff4dc68b6e: Interpret search tokens in the for "_..." as substring search (authored by epriestley).Mar 10 2021, 8:00 PM

epriestley added a task: T13632: Compile `_...` search tokens as substring searches.

epriestley added an edge: D21602: Interpret search tokens in the for "_..." as substring search.

Harbormaster completed building B25235: rP4cff4dc68b6e: Interpret search tokens in the for "_..." as substring search.Mar 10 2021, 8:00 PM

Changes (2)

Path

Size

src/

applications/

search/

compiler/

PhutilSearchQueryCompiler.php

__tests__/

PhutilSearchQueryCompilerTestCase.php

rP4cff4dc68b6e

View Options

src/applications/search/compiler/PhutilSearchQueryCompiler.php