Differential D21586

Refuse to acquire a second GlobalLock on a connection
ClosedPublic
Actions

Authored by epriestley on Mar 2 2021, 9:38 PM.

Details

Reviewers: None
Maniphest Tasks: T13627: Until MySQL 5.7, each MySQL connection may hold only one simultaneous lock
Commits: rP4aecb6f25d12: (stable) Refuse to acquire a second GlobalLock on a connection
rP2b473558c2b3: Refuse to acquire a second GlobalLock on a connection

Summary

Ref T13627. MySQL versions older than 5.7 release held locks when a new lock is acquired.

Prevent acquisition of a second lock to prevent this.

Test Plan

Added a failing unit test, made it pass.

Diff Detail

Repository

rP Phabricator

Branch

lock3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25191
Build 34767: Run Core Tests
Build 34766: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 2 2021, 9:38 PM

Harbormaster completed remote builds in B25191: Diff 51383.Mar 2 2021, 9:39 PM

epriestley requested review of this revision.Mar 2 2021, 9:39 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2021, 9:44 PM

Closed by commit rP2b473558c2b3: Refuse to acquire a second GlobalLock on a connection (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP2b473558c2b3: Refuse to acquire a second GlobalLock on a connection.

epriestley added a commit: rP4aecb6f25d12: (stable) Refuse to acquire a second GlobalLock on a connection.Mar 3 2021, 3:26 AM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

util/

PhabricatorGlobalLock.php

16 lines

__tests__/

PhabricatorGlobalLockTestCase.php

34 lines

Diff 51383

View Options

src/infrastructure/util/PhabricatorGlobalLock.php

View Options

src/infrastructure/util/tests/PhabricatorGlobalLockTestCase.php

Refuse to acquire a second GlobalLock on a connectionClosedPublicActions