Add an internal service ref panel to repository "Storage" information
ClosedPublic
Actions

Authored by epriestley on Feb 25 2021, 8:06 PM.

Details

Reviewers: None
Maniphest Tasks: T13611: In clusters, "writable" property on bindings may not actually prevent writes
Commits: rP39077be74684: Add an internal service ref panel to repository "Storage" information

Summary

Ref T13611. Currently, the "writable" property on service bindings has no effect because of a trivial bug. Provide more information in the UI to make this kind of problem observable.

Test Plan

Viewed "Storage" section of management UI, saw a more-obvious problem with ref management (a non-writable ref is listed as writable).

Screen Shot 2021-02-25 at 12.04.12 PM.png (1×1 px, 244 KB)

Diff Detail

Repository

rP Phabricator

Branch

writable1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25169
Build 34736: Run Core Tests
Build 34735: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 25 2021, 8:06 PM

Harbormaster completed remote builds in B25169: Diff 51361.Feb 25 2021, 8:07 PM

epriestley requested review of this revision.Feb 25 2021, 8:07 PM

epriestley mentioned this in D21576: Correct behavior of "writable" Almanac service binding for repository services.Feb 25 2021, 8:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 25 2021, 8:29 PM

Closed by commit rP39077be74684: Add an internal service ref panel to repository "Storage" information (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPf970b350ea2f: Correct behavior of "writable" Almanac service binding for repository services.

epriestley added a commit: rP39077be74684: Add an internal service ref panel to repository "Storage" information.

epriestley mentioned this in T13611: In clusters, "writable" property on bindings may not actually prevent writes.Feb 25 2021, 8:31 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

management/

DiffusionRepositoryStorageManagementPanel.php

127 lines

Diff 51361

View Options

src/applications/diffusion/management/DiffusionRepositoryStorageManagementPanel.php

Add an internal service ref panel to repository "Storage" informationClosedPublicActions