Remove Facebook OAuth dependency on "security_settings" property
ClosedPublic
Actions

Authored by epriestley on Feb 19 2021, 6:25 PM.

Tags

None

Referenced Files

	F15456478: D21571.id51346.diff
	Sun, Mar 30, 10:00 AM

	F15454134: D21571.id51345.diff
	Sat, Mar 29, 4:30 PM

	F15451173: D21571.id.diff
	Fri, Mar 28, 8:35 PM

	F15444311: D21571.diff
	Thu, Mar 27, 9:01 AM

	F15422664: D21571.id51345.diff
	Sat, Mar 22, 10:04 AM

	F15422663: D21571.id51346.diff
	Sat, Mar 22, 10:04 AM

	F15422649: D21571.diff
	Sat, Mar 22, 10:00 AM

	F15331305: D21571.diff
	Fri, Mar 7, 8:45 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13615: Facebook OAuth adapter is failing with "security_settings" error
Commits: rPbe0bb68f6536: Remove Facebook OAuth dependency on "security_settings" property

Summary

Ref T13615. This property was removed from the Facebook API at some point, perhaps November 2020. Stop relying no it.

Test Plan

Created a local Facebook OAuth app, registered a new account locally.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 19 2021, 6:25 PM

Harbormaster completed remote builds in B25154: Diff 51345.Feb 19 2021, 6:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2021, 6:27 PM

epriestley requested review of this revision.

Closed by commit rPbe0bb68f6536: Remove Facebook OAuth dependency on "security_settings" property (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPbe0bb68f6536: Remove Facebook OAuth dependency on "security_settings" property.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

adapter/

PhutilFacebookAuthAdapter.php

23 lines

provider/

PhabricatorFacebookAuthProvider.php

112 lines

Diff 51346

View Options

src/applications/auth/adapter/PhutilFacebookAuthAdapter.php