Page MenuHomePhabricator

Test if "get_magic_quotes_gpc()" exists before calling it
ClosedPublic

Authored by epriestley on Feb 8 2021, 5:29 PM.

Details

Summary

Ref T13588. This function was deprecated in PHP 7.4 (see D20942) and removed in PHP8.

Test that it exists before calling it so we don't fatal in PHP8.

See https://discourse.phabricator-community.org/t/daemon-fails-on-php-8-0-2-in-utils-php-array-merge-call-w-fix/4568.

Test Plan

Used "|| true" to test the message in PHP7. No actual testing in PHP8, but a user reports a similar patch works.

Diff Detail

Repository
rP Phabricator
Branch
gpc1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25105
Build 34643: Run Core Tests
Build 34642: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2021, 5:34 PM
This revision was automatically updated to reflect the committed changes.