Test if "get_magic_quotes_gpc()" exists before calling it
ClosedPublic
Actions

Authored by epriestley on Feb 8 2021, 5:29 PM.

Tags

None

Referenced Files

	F15492499: D21549.id51294.diff
	Sat, Apr 12, 3:07 PM

	F15491524: D21549.id51295.diff
	Sat, Apr 12, 4:36 AM

	F15490306: D21549.id.diff
	Fri, Apr 11, 4:07 PM

	F15486024: D21549.diff
	Thu, Apr 10, 4:25 AM

	F15457348: D21549.id51295.diff
	Sun, Mar 30, 3:50 PM

	F15455489: D21549.id51294.diff
	Sun, Mar 30, 12:46 AM

	F15451104: D21549.diff
	Fri, Mar 28, 8:09 PM

	F15418789: D21549.diff
	Mar 21 2025, 1:29 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rP67cf80b377bd: Test if "get_magic_quotes_gpc()" exists before calling it

Summary

Ref T13588. This function was deprecated in PHP 7.4 (see D20942) and removed in PHP8.

Test that it exists before calling it so we don't fatal in PHP8.

See https://discourse.phabricator-community.org/t/daemon-fails-on-php-8-0-2-in-utils-php-array-merge-call-w-fix/4568.

Test Plan

Used "|| true" to test the message in PHP7. No actual testing in PHP8, but a user reports a similar patch works.

Diff Detail

Repository

rP Phabricator

Branch

gpc1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25105
Build 34643: Run Core Tests
Build 34642: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 8 2021, 5:29 PM

Harbormaster completed remote builds in B25105: Diff 51294.Feb 8 2021, 5:31 PM

epriestley requested review of this revision.Feb 8 2021, 5:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2021, 5:34 PM

Closed by commit rP67cf80b377bd: Test if "get_magic_quotes_gpc()" exists before calling it (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP67cf80b377bd: Test if "get_magic_quotes_gpc()" exists before calling it.

Revision Contents
Changeset List

Path

Size

support/

startup/

PhabricatorStartup.php

18 lines

Diff 51294

View Options

support/startup/PhabricatorStartup.php

Test if "get_magic_quotes_gpc()" exists before calling itClosedPublicActions