Test if "get_magic_quotes_gpc()" exists before calling it
ClosedPublic
Actions

Authored by epriestley on Feb 8 2021, 5:29 PM.

Tags

None

Referenced Files

	F15418789: D21549.diff
	Fri, Mar 21, 1:29 AM

	F15395885: D21549.diff
	Sun, Mar 16, 10:24 AM

	F15312043: D21549.id51295.diff
	Thu, Mar 6, 1:21 PM

	F15286091: D21549.id51294.diff
	Tue, Mar 4, 6:09 PM

	F15285889: D21549.id.diff
	Tue, Mar 4, 4:42 PM

	F15285869: D21549.diff
	Tue, Mar 4, 4:34 PM

	Unknown Object (File)
	Sat, Mar 1, 10:25 PM

	Unknown Object (File)
	Sat, Feb 22, 12:03 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rP67cf80b377bd: Test if "get_magic_quotes_gpc()" exists before calling it

Summary

Ref T13588. This function was deprecated in PHP 7.4 (see D20942) and removed in PHP8.

Test that it exists before calling it so we don't fatal in PHP8.

See https://discourse.phabricator-community.org/t/daemon-fails-on-php-8-0-2-in-utils-php-array-merge-call-w-fix/4568.

Test Plan

Used "|| true" to test the message in PHP7. No actual testing in PHP8, but a user reports a similar patch works.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 8 2021, 5:29 PM

Harbormaster completed remote builds in B25105: Diff 51294.Feb 8 2021, 5:31 PM

epriestley requested review of this revision.Feb 8 2021, 5:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2021, 5:34 PM

Closed by commit rP67cf80b377bd: Test if "get_magic_quotes_gpc()" exists before calling it (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP67cf80b377bd: Test if "get_magic_quotes_gpc()" exists before calling it.

Revision Contents
Changeset List

Path

Size

support/

startup/

PhabricatorStartup.php

18 lines

Diff 51295

View Options

support/startup/PhabricatorStartup.php

Test if "get_magic_quotes_gpc()" exists before calling itClosedPublicActions