Annotate the unusual use of "$callback()" in "xsprintf()"
ClosedPublic
Actions

Authored by epriestley on Feb 3 2021, 10:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 21, 3:10 PM

	Unknown Object (File)
	Mon, Jan 20, 1:39 PM

	Unknown Object (File)
	Thu, Jan 9, 1:43 PM

	Unknown Object (File)
	Dec 17 2024, 6:32 PM

	Unknown Object (File)
	Dec 14 2024, 3:00 AM

	Unknown Object (File)
	Dec 13 2024, 2:31 AM

	Unknown Object (File)
	Dec 7 2024, 5:12 PM

	Unknown Object (File)
	Dec 4 2024, 12:26 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rARCc1afa91f9ff8: Annotate the unusual use of "$callback()" in "xsprintf()"

Summary

Ref T13588. See D21500. This syntax is unusual and there are some hidden complexities involved; annotate them. See D21500 for more discussion.

Test Plan

Read text, reviewed D21500.

Diff Detail

Repository

rARC Arcanist

Branch

xsprintf1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25089
Build 34620: Run Core Tests
Build 34619: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 3 2021, 10:19 PM

Harbormaster completed remote builds in B25089: Diff 51275.Feb 3 2021, 10:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:20 PM

epriestley requested review of this revision.

Closed by commit rARCc1afa91f9ff8: Annotate the unusual use of "$callback()" in "xsprintf()" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCc1afa91f9ff8: Annotate the unusual use of "$callback()" in "xsprintf()".

epriestley mentioned this in T13588: PHP 8 Compatibility.Feb 3 2021, 10:52 PM

Revision Contents
Changeset List

Path

Size

src/

xsprintf/

xsprintf.php

12 lines

Diff 51275

View Options

Annotate the unusual use of "$callback()" in "xsprintf()"ClosedPublicActions