Page MenuHomePhabricator

Remove "final" from "private" methods in Phabricator
ClosedPublic

Authored by epriestley on Feb 3 2021, 10:11 PM.
Tags
None
Referenced Files
F20590208: D21540.id.diff
Fri, Jun 19, 9:36 PM
Unknown Object (File)
Thu, Jun 18, 12:20 AM
Unknown Object (File)
Apr 19 2026, 5:48 AM
Unknown Object (File)
Apr 17 2026, 3:36 AM
Unknown Object (File)
Apr 7 2026, 5:40 PM
Unknown Object (File)
Apr 3 2026, 1:46 PM
Unknown Object (File)
Apr 1 2026, 5:45 PM
Unknown Object (File)
Mar 27 2026, 9:27 AM
Subscribers
None

Details

Summary

Ref T13588. This has never been meaningful, but a "final private" method is specifically forbidden in PHP8.

Remove meaningless "final" from these methods, per new lint checks.

Test Plan

Ran arc lint --everything to identify affected methods, then ... | xargs -n1 arc lint --apply-patches.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:13 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.