Page MenuHomePhabricator

Remove "final" from "private" methods in Phabricator
ClosedPublic

Authored by epriestley on Feb 3 2021, 10:11 PM.
Tags
None
Referenced Files
F18230311: D21540.id.diff
Wed, Aug 20, 12:19 PM
F18101341: D21540.id.diff
Sat, Aug 9, 12:27 PM
F17943503: D21540.diff
Thu, Jul 31, 8:25 AM
Unknown Object (File)
Jun 10 2025, 1:16 PM
Unknown Object (File)
Jun 7 2025, 12:51 AM
Unknown Object (File)
Jun 5 2025, 5:07 PM
Unknown Object (File)
Jun 2 2025, 5:23 AM
Unknown Object (File)
May 30 2025, 10:46 AM
Subscribers
None

Details

Summary

Ref T13588. This has never been meaningful, but a "final private" method is specifically forbidden in PHP8.

Remove meaningless "final" from these methods, per new lint checks.

Test Plan

Ran arc lint --everything to identify affected methods, then ... | xargs -n1 arc lint --apply-patches.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:13 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.