Page MenuHomePhabricator

Remove "final" from "private" methods in Phabricator
ClosedPublic

Authored by epriestley on Feb 3 2021, 10:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 10, 8:04 AM
Unknown Object (File)
Apr 27 2025, 8:34 PM
Unknown Object (File)
Apr 12 2025, 12:07 PM
Unknown Object (File)
Apr 10 2025, 11:47 PM
Unknown Object (File)
Apr 10 2025, 7:19 PM
Unknown Object (File)
Apr 9 2025, 6:41 PM
Unknown Object (File)
Apr 8 2025, 10:16 PM
Unknown Object (File)
Apr 6 2025, 9:16 PM
Subscribers
None

Details

Summary

Ref T13588. This has never been meaningful, but a "final private" method is specifically forbidden in PHP8.

Remove meaningless "final" from these methods, per new lint checks.

Test Plan

Ran arc lint --everything to identify affected methods, then ... | xargs -n1 arc lint --apply-patches.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 10:13 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.