Page MenuHomePhabricator

Internally, align commit processing tasks around PHIDs, not IDs
ClosedPublic

Authored by epriestley on Feb 1 2021, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 1:39 PM
Unknown Object (File)
Sun, Dec 22, 6:32 AM
Unknown Object (File)
Mon, Dec 16, 6:25 PM
Unknown Object (File)
Sat, Dec 14, 2:51 PM
Unknown Object (File)
Sat, Dec 7, 7:39 AM
Unknown Object (File)
Nov 25 2024, 6:55 AM
Unknown Object (File)
Nov 22 2024, 2:35 AM
Unknown Object (File)
Nov 21 2024, 4:25 AM
Subscribers
None

Details

Summary

Ref T13591. This is a minor consistency change to use PHIDs instead of IDs in the commit import processing pipeline. PHIDs are generally more powerful in more contexts and it would be unusual for a modern worker to use an ID here.

Test Plan
  • Made the "accept either ID or PHID" part of the change only.
  • Pushed a commit, parsed and reparsed it step by step (this tests that "commitID" tasks can still process normally).
  • Made the "write PHIDs" part of the change.
  • Pushed a commit, parsed and reparsed it step by step.
  • Looked at the task row in the database, saw PHID data.

Diff Detail

Repository
rP Phabricator
Branch
phase4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25068
Build 34589: Run Core Tests
Build 34588: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 2 2021, 9:40 PM
This revision was automatically updated to reflect the committed changes.