Ref T13591. This is a minor consistency change to use PHIDs instead of IDs in the commit import processing pipeline. PHIDs are generally more powerful in more contexts and it would be unusual for a modern worker to use an ID here.
Details
Details
- Made the "accept either ID or PHID" part of the change only.
- Pushed a commit, parsed and reparsed it step by step (this tests that "commitID" tasks can still process normally).
- Made the "write PHIDs" part of the change.
- Pushed a commit, parsed and reparsed it step by step.
- Looked at the task row in the database, saw PHID data.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phase4
- Lint
Lint Passed Severity Location Code Message Advice src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php:22 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 25068 Build 34589: Run Core Tests Build 34588: arc lint + arc unit