Page MenuHomePhabricator

Fix reading of the request path when running the PHP builtin webserver
ClosedPublic

Authored by epriestley on Jan 11 2021, 6:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 1, 1:45 PM
Unknown Object (File)
Wed, Jul 1, 5:58 AM
Unknown Object (File)
Apr 4 2026, 8:05 PM
Unknown Object (File)
Apr 2 2026, 1:35 AM
Unknown Object (File)
Apr 2 2026, 1:35 AM
Unknown Object (File)
Mar 15 2026, 12:18 PM
Unknown Object (File)
Mar 4 2026, 10:43 AM
Unknown Object (File)
Jan 9 2026, 11:31 PM
Subscribers
None

Details

Summary

Ref T13575. Since PHP builtin webserver support was added, the pathway for parsing request parameters became more complex. We now rebuild "$_REQUEST" later, and this rebuild will destroy any mutations made to it here, so the assignment to __path__ is lost.

Instead of "validating" the request path, make this method "read" the request path and store it explicitly, so it will survive any later request mutations.

Test Plan
  • Submitted any POST form while running Phabricator under the builtin PHP webserver. Old behavior was an error when accessing __path__; new behavior is a working application.
  • Loaded normal pages, etc.

Diff Detail

Repository
rP Phabricator
Branch
php1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25002
Build 34493: Run Core Tests
Build 34492: arc lint + arc unit