Page MenuHomePhabricator

Ensure __path__ is set on POST requests when running on CLI webserver
Needs ReviewPublic

Authored by Firehed on Mon, Nov 11, 6:27 PM.

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Summary

Ref D20046 and https://secure.phabricator.com/D20046#254987 - the change causes the manually-set $REQUEST['__path__'] variable to get unset when $REQUEST is rebuilt from the original superglobals. This copies the value into $_GET in the CLI checks to ensure its available to the rebuilds (without duplicating the conditional logic in that method)

Test Plan

On a completely clean install of Phabricator running under CLI webserver, I finally succeeded at registering (in effect, the first ever POST request to the installation)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Firehed created this revision.Mon, Nov 11, 6:27 PM
Firehed requested review of this revision.Mon, Nov 11, 6:27 PM