Ref D20046 and https://secure.phabricator.com/D20046#254987 - the change causes the manually-set $REQUEST['__path__'] variable to get unset when $REQUEST is rebuilt from the original superglobals. This copies the value into $_GET in the CLI checks to ensure its available to the rebuilds (without duplicating the conditional logic in that method)
Details
Details
- Reviewers
Firehed - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T13575: PHP built-in webserver fails on POST
On a completely clean install of Phabricator running under CLI webserver, I finally succeeded at registering (in effect, the first ever POST request to the installation)
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
See T13575. This change should be obsoleted by D21506.
D21506 is pretty much just a higher-complexity version of this change that attempts to make this pathway a bit more robust to similar "rebuild the $_REQUEST superglobal"-style changes in the future. As far as I could tell, the description of the issue here is correct and this patch was likely the simplest correct change.