Page MenuHomePhabricator

Fix reading of the request path when running the PHP builtin webserver
ClosedPublic

Authored by epriestley on Jan 11 2021, 6:34 PM.
Tags
None
Referenced Files
F14756076: D21506.id51192.diff
Tue, Jan 21, 7:05 PM
F14754268: D21506.id51189.diff
Tue, Jan 21, 3:28 PM
F14746073: D21506.diff
Tue, Jan 21, 9:38 AM
Unknown Object (File)
Thu, Jan 2, 1:39 AM
Unknown Object (File)
Tue, Dec 31, 9:23 PM
Unknown Object (File)
Dec 22 2024, 5:49 PM
Unknown Object (File)
Dec 10 2024, 8:57 AM
Unknown Object (File)
Nov 28 2024, 11:52 AM
Subscribers
None

Details

Summary

Ref T13575. Since PHP builtin webserver support was added, the pathway for parsing request parameters became more complex. We now rebuild "$_REQUEST" later, and this rebuild will destroy any mutations made to it here, so the assignment to __path__ is lost.

Instead of "validating" the request path, make this method "read" the request path and store it explicitly, so it will survive any later request mutations.

Test Plan
  • Submitted any POST form while running Phabricator under the builtin PHP webserver. Old behavior was an error when accessing __path__; new behavior is a working application.
  • Loaded normal pages, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable