Differential D21505

Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500
ClosedPublic
Actions

Authored by jrtc27 on Jan 11 2021, 4:39 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC687cb41ace6c: Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500

Summary

Calling 'Foo::bar' is only supported since PHP 7, whereas the array form
is supported since PHP 5.4, which is below our PHP 5.5 baseline.

Test Plan

No regressions under PHP 8 and snippet tested on 3v4l

Diff Detail

Repository

rARC Arcanist

Branch

php-8

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 24992
Build 34482: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Jan 11 2021, 4:39 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 11 2021, 4:39 AM

jrtc27 requested review of this revision.Jan 11 2021, 4:39 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 11 2021, 4:39 AM

Harbormaster completed remote builds in B24992: Diff 51179.Jan 11 2021, 4:39 AM

epriestley accepted this revision.Jan 11 2021, 4:39 AM

This revision is now accepted and ready to land.Jan 11 2021, 4:39 AM

Closed by commit rARC687cb41ace6c: Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500 (authored by jrtc27). · Explain WhyJan 11 2021, 4:40 AM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rARC687cb41ace6c: Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500.

epriestley mentioned this in rARC90ac9a2ff281: Fix ArcanistFormattedStringXHPASTLinterRule for PHP 8.Jan 11 2021, 4:41 AM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistFormattedStringXHPASTLinterRule.php

5 lines

Diff 51179

View Options

src/lint/linter/xhpast/rules/ArcanistFormattedStringXHPASTLinterRule.php

Fix ArcanistFormattedStringXHPASTLinterRule on older PHP after D21500ClosedPublicActions