Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint
ClosedPublic
Actions

Authored by jrtc27 on Jan 11 2021, 3:00 AM.

Details

Reviewers

epriestley
joshuaspence

Group Reviewers

Blessed Reviewers

Commits

rARC09cff8611ba4: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint

Summary

Recent JSHint improves the warning and attributes it to the equals sign
rather than the end of the expression (changed in 897e0359ce19, first
released in 2.11.0-rc1).

Test Plan

Ran arc unit with JSHint 2.12.0

Diff Detail

Repository

rARC Arcanist

Branch

php-8

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24987
Build 34477: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Jan 11 2021, 3:00 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 11 2021, 3:00 AM

jrtc27 requested review of this revision.Jan 11 2021, 3:00 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 11 2021, 3:00 AM

Harbormaster completed remote builds in B24987: Diff 51174.Jan 11 2021, 3:00 AM

🤷

This revision is now accepted and ready to land.Jan 11 2021, 3:42 AM

Rebased patch series

Harbormaster completed remote builds in B24996: Diff 51183.Jan 11 2021, 4:48 AM

Closed by commit rARC09cff8611ba4: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint (authored by jrtc27). · Explain WhyJan 11 2021, 4:51 AM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rARC09cff8611ba4: Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHint.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

jshint/

expected-conditional.lint-test

2 lines

Diff 51174

View Options

src/lint/linter/tests/jshint/expected-conditional.lint-test

Fix ArcanistJSHintLinterTestCase::testLinter for recent JSHintClosedPublicActions