This combination does not make sense and PHP 8 errors with:
Private methods cannot be final as they are never overridden by other classes
Thus remove the redundant final from all such functions.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T13588: PHP 8 Compatibility
- Commits
- rARC3ab2b407db4a: Remove final from private functions for PHP 8 compatibility
- Required Signatures
L28 Phacility Individual Contributor License Agreement
Used to create this revision with PHP 8 on macOS
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thanks! There are some similar linters already (e.g., for final in a final class, or final on an abstract method) but this particular combination (private + final) slipped through. I'll add a linter so these don't get re-introduced and apply an equivalent change to Phabricator.
Comment Actions
I added you to Blessed Committers, so you should be able to arc land this yourself. See the description of that project for more detailed instructions, or let me know if you run into issues. "Land Revision" here in the web UI should also work, or I can just pull it for you if that's easier.