Differential D21493

Separate Herald transcripts into several different views
ClosedPublic
Actions

Authored by epriestley on Nov 7 2020, 12:20 AM.

Tags

None

Referenced Files

	F13071684: D21493.diff
	Mon, Apr 22, 4:23 PM

	Unknown Object (File)
	Sat, Apr 20, 5:27 PM

	Unknown Object (File)
	Wed, Apr 17, 3:17 PM

	Unknown Object (File)
	Mon, Mar 25, 1:24 AM

	Unknown Object (File)
	Mar 1 2024, 4:44 PM

	Unknown Object (File)
	Feb 29 2024, 9:06 AM

	Unknown Object (File)
	Feb 26 2024, 5:15 PM

	Unknown Object (File)
	Feb 21 2024, 4:29 PM

View All 72 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13586: In Herald transcripts, surface exceptions encountered while evaluating fields
Commits: rP5408429466b5: Separate Herald transcripts into several different views

Summary

Ref T13586. The Herald transcript page has become more and more complicated over time, and recently added "Transactions" and "Profiler" sections. Split these across separate navigation tabs to limit the maximum complexity of any single view and make it easier to navigate to particular sections, like the profiler section.

Test Plan

Viewed various transcripts, saw nice digestible sections.

Diff Detail

Repository

Branch

herald1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25139
Build 34692: Run Core Tests
Build 34691: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 7 2020, 12:20 AM

Harbormaster completed remote builds in B24970: Diff 51156.Nov 7 2020, 12:21 AM

epriestley requested review of this revision.Nov 7 2020, 12:21 AM

Fix regexp issue.

Harbormaster completed remote builds in B25139: Diff 51329.Feb 17 2021, 4:06 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2021, 7:16 PM

Closed by commit rP5408429466b5: Separate Herald transcripts into several different views (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5408429466b5: Separate Herald transcripts into several different views.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

application/

PhabricatorHeraldApplication.php

4 lines

controller/

HeraldTranscriptController.php

219 lines

Diff 51329

src/applications/herald/application/PhabricatorHeraldApplication.php

Loading...

src/applications/herald/controller/HeraldTranscriptController.php

Loading...